raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10
No description
22659 commits 1 branch 31 tags 268 MiB
Find a file
Mark Hammons f32d6c5a68 Don't return Iterable(null) when Probe.fishForMessage times out (#25629) 
* Fix for issue #25616

I haven't had a chance to test this, but it looks to me that this is the solution to issue #25616. 

My stacktrace in this issue is this: 
```
java.lang.NullPointerException
	at eu.phy_awaas.irods.typed.lockingsystem.IRODSLockManagerSpec.$anonfun$new$20(IRODSLockManagerSpec.scala:91)
	at akka.actor.testkit.typed.internal.TestProbeImpl.loop$1(TestProbeImpl.scala:189)
	at akka.actor.testkit.typed.internal.TestProbeImpl.loop$1(TestProbeImpl.scala:201)
	at akka.actor.testkit.typed.internal.TestProbeImpl.fishForMessage_internal(TestProbeImpl.scala:215)
	at akka.actor.testkit.typed.internal.TestProbeImpl.fishForMessage_internal(TestProbeImpl.scala:45)
	at akka.actor.testkit.typed.scaladsl.TestProbe.fishForMessage(TestProbe.scala:175)
	at akka.actor.testkit.typed.scaladsl.TestProbe.fishForMessage$(TestProbe.scala:174)
	at akka.actor.testkit.typed.internal.TestProbeImpl.fishForMessage(TestProbeImpl.scala:45)
	at akka.actor.testkit.typed.scaladsl.TestProbe.fishForMessage(TestProbe.scala:181)
	at akka.actor.testkit.typed.scaladsl.TestProbe.fishForMessage$(TestProbe.scala:180)
	at akka.actor.testkit.typed.internal.TestProbeImpl.fishForMessage(TestProbeImpl.scala:45)
	at eu.phy_awaas.irods.typed.lockingsystem.IRODSLockManagerSpec.$anonfun$new$18(IRODSLockManagerSpec.scala:88)
	at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
	at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
	at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
	at org.scalatest.Transformer.apply(Transformer.scala:22)
	at org.scalatest.Transformer.apply(Transformer.scala:20)
	at org.scalatest.WordSpecLike$$anon$1.apply(WordSpecLike.scala:1078)
	at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)
	at org.scalatest.TestSuite.withFixture$(TestSuite.scala:195)
	at org.scalatest.WordSpec.withFixture(WordSpec.scala:1881)
	at org.scalatest.WordSpecLike.invokeWithFixture$1(WordSpecLike.scala:1076)
	at org.scalatest.WordSpecLike.$anonfun$runTest$1(WordSpecLike.scala:1088)
	at org.scalatest.SuperEngine.runTestImpl(Engine.scala:289)
	at org.scalatest.WordSpecLike.runTest(WordSpecLike.scala:1088)
	at org.scalatest.WordSpecLike.runTest$(WordSpecLike.scala:1070)
	at org.scalatest.WordSpec.runTest(WordSpec.scala:1881)
	at org.scalatest.WordSpecLike.$anonfun$runTests$1(WordSpecLike.scala:1147)
	at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:396)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:384)
	at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:373)
	at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:410)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:384)
	at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:373)
	at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:410)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:384)
	at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:379)
	at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:461)
	at org.scalatest.WordSpecLike.runTests(WordSpecLike.scala:1147)
	at org.scalatest.WordSpecLike.runTests$(WordSpecLike.scala:1146)
	at org.scalatest.WordSpec.runTests(WordSpec.scala:1881)
	at org.scalatest.Suite.run(Suite.scala:1147)
	at org.scalatest.Suite.run$(Suite.scala:1129)
	at org.scalatest.WordSpec.org$scalatest$WordSpecLike$$super$run(WordSpec.scala:1881)
	at org.scalatest.WordSpecLike.$anonfun$run$1(WordSpecLike.scala:1192)
	at org.scalatest.SuperEngine.runImpl(Engine.scala:521)
	at org.scalatest.WordSpecLike.run(WordSpecLike.scala:1192)
	at org.scalatest.WordSpecLike.run$(WordSpecLike.scala:1190)
	at eu.phy_awaas.irods.typed.lockingsystem.IRODSLockManagerSpec.org$scalatest$BeforeAndAfterAll$$super$run(IRODSLockManagerSpec.scala:22)
	at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)
	at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
	at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
	at eu.phy_awaas.irods.typed.lockingsystem.IRODSLockManagerSpec.run(IRODSLockManagerSpec.scala:22)
	at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:45)
	at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13(Runner.scala:1340)
	at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13$adapted(Runner.scala:1334)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:1334)
	at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24(Runner.scala:1031)
	at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24$adapted(Runner.scala:1010)
	at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:1500)
	at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:1010)
	at org.scalatest.tools.Runner$.run(Runner.scala:850)
	at org.scalatest.tools.Runner.run(Runner.scala)
	at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.runScalaTest2(ScalaTestRunner.java:131)
	at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.main(ScalaTestRunner.java:28)
```

With the calling code looking like this:

```scala
        val lockResults =
          probe.fishForMessage(Duration.create(10000, "ms"))(l => {
            r += 1
            if (r < 5) {
              l.lock.use(())//crash happens here
              FishingOutcomes.continue
            } else {
              l.lock.use(())
              FishingOutcomes.complete
            }
          })
```

It's pretty obvious receiveOne(timeout) returns a null when it receives nothing before the timeout, passes that along to my fisher function, which tries to perform work on the supposed message only to get a null instead.

* Added missing brace

* Manually formatted my code the way akka likes

I don't have the set up to compile this right now, so I just manually inserted the formatting that jenkins mentioned.

* More changes to fit the akka formatting standard

* Test for the new assertion error when fishing times out.

* Cleaned up a flaw I added from when I initially put this in async spec
2018-10-15 14:02:58 +02:00
.github Link from github issue template to discuss.akka.io 2018-06-06 11:48:11 +02:00
akka-actor/src/main Don't warn about old DNS protocol use 2018-10-05 13:43:25 +02:00
akka-actor-testkit-typed/src Don't return Iterable(null) when Probe.fishForMessage times out (#25629) 2018-10-15 14:02:58 +02:00
akka-actor-tests/src/test Merge pull request #25593 from akka/wip-25592-terminated-patriknw 2018-10-03 16:54:55 +02:00
akka-actor-typed/src/main Max number of restarts for typed supervision backoff #25584 (#25772) 2018-10-12 08:06:46 +01:00
akka-actor-typed-tests/src/test Max number of restarts for typed supervision backoff #25584 (#25772) 2018-10-12 08:06:46 +01:00
akka-agent/src Remove some of Unused import warning (#24650) 2018-03-16 12:08:29 +01:00
akka-bench-jmh Fix several minor typos detected by github.com/client9/misspell (#25448) 2018-08-21 11:02:37 +09:00
akka-camel/src Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-cluster Treat MemberStatus.Removed as terminal state in ClusterReadView (#25499) 2018-10-03 14:01:38 +02:00
akka-cluster-metrics/src Enable header plugin for the MultiJVM configuration (#24974) 2018-04-25 00:03:55 +09:00
akka-cluster-sharding/src Merge pull request #25625 from btomala/feature/25348_missing_serializers_for_shard_region 2018-10-15 13:30:42 +02:00
akka-cluster-sharding-typed/src rename PersistentBehaviors.receive to PersistentBehavior.apply 2018-10-09 13:47:22 +02:00
akka-cluster-tools/src Merge pull request #25565 from johanandren/wip-down-removal-margin-take-two-johanandren 2018-09-20 09:03:34 +02:00
akka-cluster-typed/src Docs for typed distributed data (#25747) 2018-10-12 08:14:01 +01:00
akka-contrib Fix several minor typos detected by github.com/client9/misspell (#25448) 2018-08-21 11:02:37 +09:00
akka-distributed-data/src Revert Support for rolling upgrade of ORSet[ActorRef], #25336 2018-09-11 15:15:36 +02:00
akka-docs/src fixed typo in DNS extension documentation (#25789) 2018-10-12 18:16:00 +01:00
akka-multi-node-testkit/src/main Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-osgi/src Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-persistence/src Add inclusive to deletion api docs (#25390) 2018-08-23 09:13:53 +01:00
akka-persistence-query/src Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-persistence-shared/src/test/scala/akka/persistence Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-persistence-tck/src Don't require journal to have predictable highestSeq.Nr. #25329 2018-09-03 12:16:41 +02:00
akka-persistence-typed/src rename PersistentBehaviors.receive to PersistentBehavior.apply 2018-10-09 13:47:22 +02:00
akka-protobuf/src/main/java/akka/protobuf Fix several minor typos detected by github.com/client9/misspell (#25448) 2018-08-21 11:02:37 +09:00
akka-remote/src Deprecation and documentation for the AESCounterBuiltinRNG issue 2018-08-29 18:25:37 +02:00
akka-remote-tests/src Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-slf4j/src Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-ssl-config/src/main/scala/com/lightbend/sslconfig/akka Update copyright to 2018 (#24241) 2018-01-04 17:26:29 +00:00
akka-stream/src/main Modified iff statements from JavaDSL/Flow.scala (#25785) 2018-10-12 10:07:30 +02:00
akka-stream-testkit/src Merge pull request #25353 from chbatey/issue-24956-streamtestkitspec 2018-08-23 11:34:04 +02:00
akka-stream-tests/src/test example for reduce operator #25468 2018-10-08 16:15:33 +02:00
akka-stream-tests-tck/src/test Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
akka-stream-typed/src make scalatest suite type agnostic 2018-09-17 17:54:54 +02:00
akka-testkit/src Reset timeout for fixed restarts 2018-09-20 08:36:01 +01:00
project Merge pull request #25764 from dwijnand/ssl-config 2018-10-11 12:35:52 +02:00
scripts New authors-script for releasing (#21783) 2016-11-02 14:45:02 +01:00
src/main/ls
.gitignore Drop the exec bit on non-executable files 2017-05-23 16:06:27 +02:00
.java-version =per,tck #18639 introduce capability flags for journal features 2015-11-27 10:29:34 +01:00
.travis.yml Upgrade to scala 2.12.7 2018-09-27 16:08:09 +01:00
build.sbt Merge pull request #25563 from akka/wip-manifest-version-patriknw 2018-09-18 19:50:35 +02:00
CODE_OF_CONDUCT.md Add Code of Conduct, inspired by Play Framework's (#23673) 2017-09-21 19:23:19 +09:00
CONTRIBUTING.md Java API checklist (#25762) 2018-10-12 13:06:42 +02:00
COPYING.protobuf
LICENSE Include the full apache license text (#23992) 2017-11-14 16:47:33 +01:00
README.md Fix README scladex badge (#25471) 2018-08-14 09:45:11 +02:00
RELEASING.md Add grpc samples to RELEASING.md 2018-08-24 13:38:53 +02:00

README.md

Akka scaladex-badge

We believe that writing correct concurrent & distributed, resilient and elastic applications is too hard. Most of the time it's because we are using the wrong tools and the wrong level of abstraction.

Akka is here to change that.

Using the Actor Model we raise the abstraction level and provide a better platform to build correct concurrent and scalable applications. This model is a perfect match for the principles laid out in the Reactive Manifesto.

For resilience, we adopt the "Let it crash" model which the telecom industry has used with great success to build applications that self-heal and systems that never stop.

Actors also provide the abstraction for transparent distribution and the basis for truly scalable and fault-tolerant applications.

Learn more at akka.io.

Reference Documentation

The reference documentation is available at doc.akka.io, for Scala and Java.

Community

You can join these groups and chats to discuss and ask Akka related questions:

In addition to that, you may enjoy following:

Contributing

Contributions are very welcome!

If you see an issue that you'd like to see fixed, the best way to make it happen is to help out by submitting a pull request implementing it.

Refer to the CONTRIBUTING.md file for more details about the workflow, and general hints on how to prepare your pull request. You can also ask for clarifications or guidance in GitHub issues directly, or in the akka/dev chat if a more real time communication would be of benefit.

A chat room is available for all questions related to developing and contributing to Akka: gitter: akka/dev

License

Akka is Open Source and available under the Apache 2 License.