Commit graph

1878 commits

Author SHA1 Message Date
Philippus Baalman
90bf989630 Replace scalactic deprecations (#25886) 2018-11-09 09:07:21 +01:00
kerr
fafc59b19d update headers to regular comment (#25807) 2018-10-29 05:19:37 -04:00
Patrik Nordwall
b75bb8fc46 Deprecation and documentation for the AESCounterBuiltinRNG issue
* reproducer test of AESCounterBuiltinRNG issue
* update documentation of random-number-generator
* deprecate AES128CounterSecureRNG AES256CounterSecureRNG
* incorporate feedback from Johannes
2018-08-29 18:25:37 +02:00
Rafał Sumisławski
56498e7e58 Fix vulnerability in AESCounterBuiltinRNG
* The problem is that that internal counter isn’t incremented before cipher.doFinal() is used
* AES/CTR has a counter internally and cipher.update() should be used
* Another issue is that AES128CounterSecureRNG is initially seeded with a 16 bytes seed/key, but once it
  hits ReseedingThreshold it reseeds itself with a 32 bytes seed, effectively becoming AES256. This will
  crash if strong encryption is disabled.
2018-08-29 18:24:43 +02:00
Johan Andrén
3b594e14de
Merge pull request #25521 from akka/wip-artery-queue-sizes-patriknw
increase outbound-control-queue-size
2018-08-28 13:31:30 +02:00
Patrik Nordwall
d5b2aea176
Merge pull request #25035 from piotrromanski/wip-fix-math-abs-usage
Handle a negative value returned by Math.abs()
2018-08-27 16:29:32 +02:00
Patrik Nordwall
951f5a58fc increase outbound-control-queue-size
* since it's a linked queue nowadays it's fine to have a higher limit
* using 20000, since that is also the default of the system messages buffer
2018-08-24 15:48:02 +02:00
Patrik Nordwall
b9aecb7f5a
Merge pull request #25416 from chbatey/nits
Remove various compiler warnings
2018-08-23 11:36:57 +02:00
Kazuhiro Sera
482eaea122 Fix several minor typos detected by github.com/client9/misspell (#25448)
* Fix several minor typos detected by github.com/client9/misspell

* Revert s/erminater/erminator/ in /ActorSystemSpec
2018-08-21 11:02:37 +09:00
Christopher Batey
7299d6b26c
Harden BindCanonicalAddressSpec (#25404)
The randomly selected port by Artery could be the same as the randomly
selected port the test generates.

Fixes #25403
2018-08-20 13:56:11 +01:00
Patrik Nordwall
1cdc3c8970 explicit return type in ThrottlerTransportAdapter Java API (#25474) 2018-08-16 12:18:34 +02:00
Vladimir Leletko
973e8bfa23 https://github.com/akka/akka/issues/25429: add direction & throttler instances accessors to ThrottlerTransportAdapter module. add java compile only tests. (#25465) 2018-08-13 12:35:59 +09:00
Christopher Batey
a0e79a0542 Log exception for association failure (#25438)
There have been cases where the thrown
NettyTransportExceptionNoStackTrace contains no cause
and a message that doesn't indicate what type of exception has been
thrown when establishing a connection.
2018-08-06 18:17:58 +09:00
Christopher Batey
c53809c3b8 Remove various compiler warnings 2018-07-31 17:18:40 +01:00
Johan Andrén
85ffc17973 Stack trace changes depending on how throwable is constructed in JDK9+ (#25408)
This changes the test to not compare stacktraces with equals to avoid
test failures.
2018-07-31 00:08:10 +09:00
kenji yoshida
5b3b191bac Remove procedure syntax (#25362) 2018-07-25 13:38:27 +02:00
Philippus Baalman
3cf87a1c12 Remove duplicate 'for' in code comments (#25366) 2018-07-19 00:08:51 +09:00
Patrik Nordwall
231672fc1c
Merge pull request #25308 from DataDome/akka_remote_shutdown_warning
Changed log-level of ShutDownAssociation from Error to Warning
2018-07-11 13:30:39 +02:00
Christopher Batey
836347fe08 Typed persistence: Throw on persist failures, #24479
* Rather than stop so that users can add their own supervision e.g.
restartWithBackOff
* Only allow back off supervisoir for persistent behaviors
* Handle persist rejections
2018-07-09 10:57:36 +02:00
Kirill A. Korinsky
27601f5107
Changed log-level of ShutDownAssociation from Error to Warning
When the node has left the cluster, existed nodes throw
akka.remote.transport.Transport$InvalidAssociationException with message `The
remote system terminated the association because it is shutting down`.

This error normally happened when node is leaving the cluster in redeployment
proposal and it isn't an error but it creates a noise in monitoring/alert system.

So, I propose to log it as Warning.
2018-07-06 00:45:14 +02:00
Roman Filonenko
4d31d7ce49 log address having heartbeat problems in PhiAccrualFailureDetector (#24701) (#25237)
* log address having heartbeat problems in PhiAccrualFailureDetector (#24701)

* update binary compatibility comments
2018-06-27 07:19:36 +02:00
Roman Filonenko
427124a531 increase threshold to publish heartbeat interval warnings in PhiAccrualFailureDetector (#25253) (#25259) 2018-06-26 16:14:25 +02:00
Richard S. Imaoka
bf8f60f1ff no need to rename to operators in internal API 2018-06-17 13:17:59 +09:00
Richard S. Imaoka
60eee84345 Replace graph with operator in Scaladoc/Javadoc 2018-06-09 17:42:56 +09:00
Christopher Batey
1787283757 Log receiving of heartbeats when verbose heartbeat logging is on (#25183) 2018-06-04 16:22:06 +03:00
Patrik Nordwall
73284fd897 log discarded messages in read-only endpoint #25127 2018-05-29 12:47:09 +02:00
Patrik Nordwall
cf864a940f limit negative acknowledgement logging, #25143 2018-05-28 09:11:51 +02:00
Patrik Nordwall
3439377816
Merge pull request #24983 from akka/wip-24972-tcp-restart-patriknw
Quarantine and cleanup idle associations, #24972
2018-05-22 13:11:36 +02:00
Patrik Nordwall
7fc7744049 Quarantine and cleanup idle associations, #24972
* fix NPE in shutdownTransport
  * perhaps because shutdown before started
  * system.dispatcher is used in other places of the shutdown
* improve logging of compression advertisment progress
* adjust RestartFlow.withBackoff parameters
* quarantine after ActorSystemTerminating signal
  (will cleanup compressions)
* Quarantine idle associations
  * liveness checks by sending extra HandshakeReq and update the
    lastUsed when reply received
  * concervative default value to survive network partition, in
    case no other messages are sent
* Adjust logging and QuarantinedEvent for harmless quarantine
  * Harmless if it was via the shutdown signal or cluster leaving
2018-05-22 13:10:30 +02:00
Patrik Nordwall
e6633f17fa
Make sure Serialization.currentTransportInformation is always set, #25067
* The ThreadLocal Serialization.currentTransportInformation is used for serializing local
  actor refs, but it's also useful when a serializer library e.g. custom serializer/deserializer
  in Jackson need access to the current ActorSystem.
* We set this in a rather ad-hoc way from remoting and in some persistence plugins, but it's only
  set for serialization and not deserialization, and it's easy for Persistence plugins or other
  libraries to forget this when using Akka serialization directly.
* This change is automatically setting the info when using the ordinary serialize and deserialize
  methods.
* It's also set when LocalActorRefProvider, which wasn't always the case previously.
* Keep a cached instance of Serialization.Information in the provider to avoid
  creating new instances all the time.
* Added optional Persistence TCK tests to verify that the plugin is setting this
  if it's using some custom calls to the serializer.
2018-05-21 16:59:04 +02:00
Johan Andrén
b27bdba13b
Do not tear down connections on IllegalArgumentException from serializer #24910 2018-05-16 15:35:05 +02:00
Patrik Nordwall
969cdb873a
Merge pull request #25020 from chbatey/upgrade-aeron
Upgrade Aeron and make use of channelStatus on subscription
2018-05-07 16:56:03 +02:00
promanski
05282b59c9 Handle a negative value returned by Math.abs() #25034 2018-05-05 13:49:20 +02:00
Christopher Batey
c0f18c96d3 Disable TlsTcpWithActorSystemSetupSpec when not running tcp-tls tests 2018-05-01 09:49:51 +01:00
Christopher Batey
0d9aa17fef Upgrade Aeron and make use of channelStatus on subscription 2018-04-30 14:39:06 +01:00
Patrik Nordwall
27e9587a3b Configurable SSLEngineProvider in classic remoting, #23732 2018-04-30 10:24:34 +02:00
Christopher Batey
4d20b2a660 Reduce size of jenkins logs
Each build is now over 40mb logs.

A lot of DEBUG logging was left on for test failures that have been
fixed. Added an issue # for ones that are still valid or if if it on
as the test verifies debug
2018-04-24 08:49:41 +01:00
Kirill Yankov
3ebb9fa9c1 Fix serialization in TypedActor (#24851)
* fixed serialization in TypedActor
* generalized duplicates via Serialization.manifestFor
2018-04-12 18:58:13 +02:00
Patrik Nordwall
43dc381d59
Clear system messages sequence number for restarted node, #24847
* Notice that the incarnation has changed in SystemMessageDelivery
  and then reset the sequence number
* Take the incarnation number into account in the ClearSystemMessageDelivery
  message
* Trigger quarantine earlier in ClusterRemoteWatcher if node with
  same host:port joined
* Change quarantine-removed-node-after to 5s, shouldn't be necessary
  to delay it 30s
* test reproducer
2018-04-10 11:39:55 +02:00
Patrik Nordwall
332aa58540 clarify the resolve debug logging (#24858) 2018-04-09 10:39:13 +02:00
Christopher Batey
74f39e9409 ArteryMessageLoggingSpec pick up command line overrides for akka settings
Use ConfigFactory.load to pick up overrides in the additional actor
system. Otherwise one runs with udp and other tcp for the artery-tcp
job.

Fixes #24806
2018-04-03 08:03:57 +01:00
Christopher Batey
c8f16845f2 Log sent/receive message log level check #24774 2018-03-27 12:20:19 +02:00
Mark James Talbot
0a426a7ab0 Change Artery TCP to use bind address (#24773) 2018-03-26 13:44:33 +02:00
Stefan Wachter
3db145643a materialized value of Flow.lazyInit must be a Future #24670 (#24685)
* change materialized value of LazyFlow from [M] to Future[Option[M]]

* remove whitespace

* improve docu

* restore old Flow.lazyInit method and add new Flow.lazyInitAsync method

* fix deprecation messages

* add 2.5.11.backwards.excludes because of changed LazyFlow constructor signature

* check switching behaviour

* apply formatting

* improve deprecation message; improve null safety

* prevent premature stage completion by setting keepGoing

* deprecate Sink.lazyInit; add Sink.lazyInitAsync

* apply formatting

* add ProblemFilter.exclude for changed LazySink.this

* Update Sink.scala

* Update Sink.scala

* Update Flow.scala

* Update Flow.scala
2018-03-19 22:42:37 +09:00
Patrik Nordwall
8847f7dfb7 less aggressive resend of Artery sys msg after nack, #24744 (#24745) 2018-03-19 00:59:44 -07:00
Jimin Hsieh
2c2b8ba001 Remove some of Unused import warning (#24650) 2018-03-16 12:08:29 +01:00
Johan Andrén
82f60226ff
Make use of the fact that identity is eliminated (#24702) 2018-03-14 09:21:47 +01:00
Konrad `ktoso` Malawski
563c7fbcf0 Issue 24594: Integration with sbt-headers and initial header population 2018-03-13 15:45:55 +01:00
Patrik Nordwall
7d67524bb5 lazy init of SerializationExtension in Artery, #24620 (#24667)
to avoid loading serializers before ActorRefProvider has been initialized
2018-03-09 16:59:33 +09:00
Roman Filonenko
0ecadf7235 deduplicate logic for IODispatcher #24604 (#24619)
* deduplicate logic for IODispatcher #24604
 * introduce a resolveDispatcher helper in ActorAttributes
 * mention akka.stream.materializer.blocking-io-dispatcher instead of akka.stream.blocking-io-dispatcher in scaladocs
 * fix a flaky test
 * cosmetic changes in the touched files

* move resolveDispather helper to the Dispatcher companion object under a new name resolve

* filter out mima warning

* fix mima excludes after the 2.5.11 release

* address review comments
 * update stream-io.md with the correct dispatcher config key
 * mark ActorAttributes.Dispatcher#resolve as internal API
 * use the dispatche config key in ActorMaterializer

* add private[akka] to the resolve methods
2018-03-07 15:12:34 +01:00