Commit graph

23512 commits

Author SHA1 Message Date
Patrik Nordwall
984f782917
Merge pull request #26921 from akka/persistentId
persistentId -> persistenceId
2019-05-16 11:41:10 +02:00
Patrik Nordwall
ce438637bb Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements
* Fixing a few other missing things
  * receiveStartEntity should process the change before starting the entity
  * lastMessageTimestamp should be touched from overridden deliverTo
  * handle StoreFailure
2019-05-16 11:39:28 +02:00
Patrik Nordwall
35e7e07488
Some more internal-dispatcher usages, #26915
* tried to investigate the (small) increase in LatencySpec that occured
  when the internal-dispatcher was introduced
* couldn't see significant difference when running locally
* found a few more places where the internal-dispatcher should be used
* my thinking is that the additional latency could have been caused by
  hopping between dispatchers, but I'm not sure if any of these
  changes will have an effect (we'll see in Jenkins job)
* more clear router props
2019-05-15 19:35:57 +02:00
Patrik Nordwall
71e9bdc262 more classic remoting leftovers
* fix several tests that were using akka.remote.netty.tcp config
* replace akka.tcp with akka in more places
* some doc cross references to remoting.md
2019-05-15 19:34:50 +02:00
Johan Andrén
18a3569a7e
Java interop via for FlowWithContext #26896 2019-05-15 10:28:12 +02:00
Johan Andrén
41f1163a68 Test for WatchWith had a race #25955 (#26925) 2019-05-14 17:43:49 +02:00
Helena Edelson
83503919b2 New ReceiveTimeout not applied if it was set while handling a messag… (#26892)
* New ReceiveTimeout not applied if it was set while handling a  message
* Test receive timeout change to probe on ReceiveTimeout of last set value.
2019-05-14 15:33:42 +02:00
Johan Andrén
8348bcc5b8
Fix for UdpConnected actor going away on PortUnreachableException #26903 2019-05-14 15:20:41 +02:00
Felix Satyaputra
9024f19cff Reduce DDataShardCoordinator memory usage during unreachability (#25444)
* stash GetShardHome requests in a Set, to keep only one per sender
* regions repeatedly send GetShardHome requests when they don't receive a response,
  keeping only one of them is better
* other existing tests cover this implicitly
2019-05-14 14:29:53 +02:00
Arnout Engelen
dae1870a10
persistentId -> persistenceId 2019-05-14 14:06:55 +02:00
Arnout Engelen
1852649d0d Determine temporary ports with SocketUtils #23337 2019-05-14 09:25:16 +02:00
Johan Andrén
32af30ee0a Restart hooks ordered list format fix (#26898) 2019-05-13 16:36:51 +01:00
Christopher Batey
c785a1cacd
Fix formatting for supervision.md (#26907)
Bullets not rendered due to missing space
2019-05-13 16:34:17 +01:00
Patrik Nordwall
0c8d46121a Disable LargeMessageClusterSpec for classic remoting, #26889 2019-05-13 15:43:59 +02:00
Arnout Engelen
e071077640
Include includes in 'behavior' snippets (#26891) 2019-05-10 09:53:55 +02:00
Johan Andrén
cd877e126f
Typed receptionist clashes with the clusterclient receptionist #26848 2019-05-09 12:59:45 +02:00
Arnout Engelen
d3adeb8e0d Clarify docs for Flow.ask generic parameter (#26701)
* Clarify docs for Flow.ask generic parameter

* Java/scala switch

* Throw specific ClassCastException in Flow.ask

Benchmark seems too noisy to draw any real conclusions, but seems not terrible:

```
pre:
Score        Error  Units
[info] AskBenchmark.mapAsync              1    false  thrpt    3  323497.536 ±  38733.024  ops/s
[info] AskBenchmark.mapAsync              1     true  thrpt    3  327001.647 ± 382202.906  ops/s
[info] AskBenchmark.mapAsync              4    false  thrpt    3  457725.806 ±  67583.859  ops/s
[info] AskBenchmark.mapAsync              4     true  thrpt    3  451728.770 ±  74886.315  ops/s

post:
[info] Benchmark              (parallelism)  (spawn)   Mode  Cnt       Score        Error  Units
[info] AskBenchmark.mapAsync              1    false  thrpt    3  338509.183 ± 160893.556  ops/s
[info] AskBenchmark.mapAsync              1     true  thrpt    3  345710.807 ± 505445.147  ops/s
[info] AskBenchmark.mapAsync              4    false  thrpt    3  737276.613 ±   3306.911  ops/s
[info] AskBenchmark.mapAsync              4     true  thrpt    3  697960.417 ± 454528.184  ops/s

[info] Benchmark              (parallelism)  (spawn)   Mode  Cnt       Score        Error  Units
[info] AskBenchmark.mapAsync              1    false  thrpt    3  349120.202 ± 111625.074  ops/s
[info] AskBenchmark.mapAsync              1     true  thrpt    3  440218.776 ± 817228.408  ops/s
[info] AskBenchmark.mapAsync              4    false  thrpt    3  665269.418 ±  10502.449  ops/s
[info] AskBenchmark.mapAsync              4     true  thrpt    3  471313.943 ±  35173.757  ops/s

```

* Formatting, use tag.runtimeClass
2019-05-08 18:57:31 +02:00
Shutao Tang
fc189e6962 Adds parentheses to method that has side-effect (#26864)
* Adds parentheses to Thread.currentThread and Lock.lock

* Removes some unnecessary parentheses and fixes typo

* Simplify Map.get(xxx).getOrElse(yyy) to Map.getOrElse(xxx, yyy)

* Adds parentheses to CountDownLatch#countDown

* Removes unnecessary new-modifier of case-class and asInstance cast
2019-05-08 18:51:15 +02:00
Johannes Rudolph
c90f5720b3
act: remove shaded fork join pool implementation
I ran a series of benchmarks and there seem to be different behaviors between the existing and JDK
ForkJoinPools especially on JDK11 and Graal. The results have been really inconclusive about which one would be a benefit overall.

In lack of better evidence, there is not much reason to keep our own copy, so there it goes.

(I couldn't reproduce the high system CPU usage with more recent JDKs that Patrik noticed when
we had it on the table the last time in #22560.)

Fixes #26180.
2019-05-08 17:30:16 +02:00
Patrik Nordwall
c74b7391f5
Merge pull request #26423 from jrudolph/jr/avoid-cas-if-not-needed
actor: Potential systemQueuePut improvement
2019-05-08 17:03:52 +02:00
Barnabás Oláh
40d3fd867b fix broken link for typed snapshots (#26882) 2019-05-08 15:03:06 +02:00
Johannes Rudolph
9ebc5b4b72 Update CONTRIBUTING.md to current release branches (#26885) 2019-05-08 10:27:02 +02:00
Helena Edelson
4bd40be864
Promote ApiMayChange features #26532 (#26838) 2019-05-07 07:01:59 -07:00
Johannes Rudolph
7b6367e56a
act: avoid ReceiveTimeout handling in hot path if no receive timeout is set (#26420)
This seems to improve ActorBenchmark by 10-20% for me.
2019-05-07 15:09:15 +02:00
Johannes Rudolph
56faa6342d
Merge pull request #26105 from akka/jr/26104-fix-SSLEngine-IllegalStateException-in-TlsActor
=str defer calling SSLEngine.closeOutbound until after handshake
2019-05-07 14:23:38 +02:00
Philippus Baalman
70c3d08b5a Update typesafe config to 1.3.4 (#26875)
Link to latest version of the Typesafe Config Library API docs
2019-05-07 12:47:26 +02:00
REASY
8c0a79b7b1 Use java.lang.StringBuilder to format timestamp (#26868) 2019-05-07 12:03:32 +02:00
Patrik Nordwall
6f7856594a fix changed idle-cpu-level property in LatencySpec (#26872) 2019-05-06 14:19:56 +02:00
Patrik Nordwall
4e5c8fe626
ResetSystemMessageSeqNrSpec should not run with classic remoting, #26849 (#26856)
* ResetSystemMessageSeqNrSpec should not run with classic remoting, #26849
* Jenkins job overrides config with -Dakka.remote.artery.enabled=off
* use Scalatest withFixture
2019-05-06 11:08:57 +02:00
Shutao Tang
c70370b4d6 Simplify the boolean expression (#26855) 2019-05-06 10:09:06 +02:00
Patrik Nordwall
3b538dc84c internal-dispatcher in akka.cluster.StartupWithOneThreadSpec (#26862) 2019-05-06 10:08:11 +02:00
Christopher Batey
25648bdf36
Be more explicit that a node is shutting down as it was marked as DOWN (#26861) 2019-05-03 14:15:22 +01:00
Patrik Nordwall
69dab98c6b
Merge pull request #26863 from akka/wip-release-script-patriknw
remove duplicate build with Scala 2.12 in release
2019-05-03 13:40:40 +02:00
Patrik Nordwall
54e5f0829b remove duplicate build with Scala 2.12 in release
* that was a workaround for building with 2.11
2019-05-03 13:37:31 +02:00
Patrik Nordwall
fbaa9a9500
Merge pull request #26860 from akka/wip-migration-fix-patriknw
cleanup migration guide
2019-05-03 12:37:22 +02:00
Christopher Batey
c65bf2d276 Remove docs for ActorPub/Sub and write persistence query docs as stages (#26844)
* use separate db columns
* Use io dispatcher for sample stage
2019-05-03 12:36:50 +02:00
Patrik Nordwall
669c688055 cleanup migration guide 2019-05-03 11:21:13 +02:00
Patrik Nordwall
2bbf13f707
Run CoordinatedShutdown from ActorSystem.terminate #25213 (#26830) 2019-05-03 10:47:47 +02:00
Johan Andrén
81b1e2ef9b Internal dispatcher to protect against starvation (#26816)
* Allow for dispatcher aliases and define a internal dispatcher
* Test checking dispatcher name
* MiMa for Dispatchers
* Migration guide entry
* No need to have custom dispatcher lookup logic in streams anymore
* Default dispatcher size and migration note about that
* Test checking exact config values...
* Typed receptionist on internal dispatcher
* All internal usages of system.dispatcher gone through
2019-05-02 22:35:25 +02:00
Patrik Nordwall
e34a711adf
Merge pull request #26831 from akka/wip-26190-actorFor-patriknw
Remove remainings of actorFor, #26190
2019-05-02 20:41:13 +02:00
Christopher Batey
e2fafb93d8 Fix config blocks in classic remoting docs (#26851)
* Fix config blocks in classic remoting docs

* Update akka-docs/src/main/paradox/remoting.md

* Update akka-docs/src/main/paradox/remoting.md
2019-05-02 20:20:02 +02:00
Patrik Nordwall
14de568570 Remove remainings of actorFor, #26190
* remove undefinedUid specials related to actorFor
* mention in migration guide
* remove special case for watch of undefinedUid
2019-05-02 19:17:40 +02:00
Johan Andrén
267d96ecf1 Remove Timing operator (#26845)
* Remove Timing operator #26188

* Mima
2019-05-02 19:11:54 +02:00
Arnout Engelen
629383545f
Clean up paradox output (#26759)
Fix some validation problems
2019-05-02 18:23:33 +02:00
Shutao Tang
8c8972c9a1 Removes the redundant val/final modifier in akka.dispatch/routing (#26822)
* Removes the redundant val/final modifier in akka.dispatch/routing

* Formats code via sbt akka-actor/scalafmtAll

* Handle one argment of map/recover/collect in akka-actor module

* Removes unuseful @param annotation
2019-05-02 18:00:43 +02:00
Patrik Nordwall
82c761f026
remove Future from StreamRefs mat val, #24372 (#26847) 2019-05-02 16:54:37 +02:00
Johan Andrén
1128024797 Increase timeout to fix PersistentActorJavaDslTest (#26799)
* Increase timeout to fix #26466
2019-05-02 14:21:13 +02:00
Arnout Engelen
282b38e832
Remove akka-contrib (#26769)
* Remove akka-contrib #26183

This module has been deprecated since 2.5 and is removed in 2.6
2019-05-02 12:09:11 +02:00
Patrik Nordwall
80fddd2317
Merge pull request #26840 from akka/removeUnicodeArrow
Remove unicode arrow
2019-05-02 08:39:25 +02:00
Patrik Nordwall
cf0329681e
Merge pull request #26835 from akka/wip-26832-assertInvariants-patriknw
Handle CoordinatedShutdown exiting-completed when not joined, #26832
2019-05-02 08:24:43 +02:00