raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Enable 'adapted args' warnings globally (#28391)

Browse source 
* Enable 'adapted args' warnings globally

* Nicer tuple notation
This commit is contained in:
Arnout Engelen 2019-12-17 13:31:34 +01:00 • committed by GitHub
parent 8948e4b6ce
commit ffe769b4df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
akka-actor/src/main/scala/akka/io/dns/internal/DnsClient.scala
View file

@ -82,21 +82,21 @@ import scala.concurrent.duration._
case Question4(id, name) =>
log.debug("Resolving [{}] (A)", name)
val msg = message(name, id, RecordType.A)
inflightRequests += (id -> (sender(), msg))
inflightRequests += (id -> (sender() -> msg))
log.debug("Message [{}] to [{}]: [{}]", id, ns, msg)
socket ! Udp.Send(msg.write(), ns)
case Question6(id, name) =>
log.debug("Resolving [{}] (AAAA)", name)
val msg = message(name, id, RecordType.AAAA)
inflightRequests += (id -> (sender(), msg))
inflightRequests += (id -> (sender() -> msg))
log.debug("Message to [{}]: [{}]", ns, msg)
socket ! Udp.Send(msg.write(), ns)
case SrvQuestion(id, name) =>
log.debug("Resolving [{}] (SRV)", name)
val msg = message(name, id, RecordType.SRV)
inflightRequests += (id -> (sender(), msg))
inflightRequests += (id -> (sender() -> msg))
log.debug("Message to [{}]: [{}]", ns, msg)
socket ! Udp.Send(msg.write(), ns)

2
project/AkkaDisciplinePlugin.scala
View file

@ -71,7 +71,7 @@ object AkkaDisciplinePlugin extends AutoPlugin with ScalafixSupport {
/**
* Remain visibly filtered for future code quality work and removing.
*/
val undisciplineScalacOptions = Set("-Ywarn-value-discard", "-Ywarn-numeric-widen", "-Yno-adapted-args")
val undisciplineScalacOptions = Set("-Ywarn-value-discard", "-Ywarn-numeric-widen")
/** These options are desired, but some are excluded for the time being*/
val disciplineScalacOptions = Set(