From fe2e5cb5a80eb940de01bf2f6c1d24c465d09619 Mon Sep 17 00:00:00 2001
From: Patrik Nordwall <patrik.nordwall@gmail.com>
Date: Tue, 4 Dec 2018 15:37:04 +0100
Subject: [PATCH] Runtime check that Netty version is 3.10.6, #25967

* Fail fast if invalid Netty version is used.
* Issue netty/netty#4739 may cause messages to not be delivered.
---
 .../transport/netty/NettyTransport.scala      | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala b/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala
index 5bcaae4a78..3be6a2da8f 100644
--- a/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala
+++ b/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala
@@ -186,6 +186,25 @@ class NettyTransportSettings(config: Config) {
       config.getDouble("pool-size-factor"),
       config.getInt("pool-size-max"))
 
+  // Check Netty version >= 3.10.6
+  {
+    val nettyVersion = org.jboss.netty.util.Version.ID
+    def throwInvalidNettyVersion(): Nothing = {
+      throw new IllegalArgumentException("akka-remote with the Netty transport requires Netty version 3.10.6 or " +
+        s"later. Version [$nettyVersion] is on the class path. Issue https://github.com/netty/netty/pull/4739 " +
+        "may cause messages to not be delivered.")
+    }
+
+    try {
+      val segments: Array[String] = nettyVersion.split("[.-]")
+      if (segments.length < 3 || segments(0).toInt != 3 || segments(1).toInt != 10 || segments(2).toInt < 6)
+        throwInvalidNettyVersion()
+    } catch {
+      case _: NumberFormatException ⇒
+        throwInvalidNettyVersion()
+    }
+  }
+
 }
 
 /**