raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Adds parentheses to method that has side-effect (#26864)

Browse source 
* Adds parentheses to Thread.currentThread and Lock.lock

* Removes some unnecessary parentheses and fixes typo

* Simplify Map.get(xxx).getOrElse(yyy) to Map.getOrElse(xxx, yyy)

* Adds parentheses to CountDownLatch#countDown

* Removes unnecessary new-modifier of case-class and asInstance cast
This commit is contained in:
Shutao Tang 2019-05-09 00:51:15 +08:00 • committed by Patrik Nordwall
parent c74b7391f5
commit fc189e6962
21 changed files with 53 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

14
akka-actor/src/main/scala/akka/pattern/AskSupport.scala
View file

@ -605,11 +605,13 @@ private[akka] final class PromiseActorRef private (
case Stopped | _: StoppedWithPath => provider.deadLetters ! message
case _ =>
if (message == null) throw InvalidMessageException("Message is null")
if (!(result.tryComplete(message match {
case Status.Success(r) => Success(r)
case Status.Failure(f) => Failure(f)
case other => Success(other)
}))) provider.deadLetters ! message
val promiseResult = message match {
case Status.Success(r) => Success(r)
case Status.Failure(f) => Failure(f)
case other => Success(other)
}
if (!result.tryComplete(promiseResult))
provider.deadLetters ! message
}
override def sendSystemMessage(message: SystemMessage): Unit = message match {
@ -639,7 +641,7 @@ private[akka] final class PromiseActorRef private (
def ensureCompleted(): Unit = {
result.tryComplete(ActorStopResult)
val watchers = clearWatchers()
if (!watchers.isEmpty) {
if (watchers.nonEmpty) {
watchers.foreach { watcher =>
// ➡➡➡ NEVER SEND THE SAME SYSTEM MESSAGE OBJECT TO TWO ACTORS ⬅⬅⬅
watcher