raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Do not invoke the supervisor twice for the same MapAsync failure #23888

Browse source
This commit is contained in:
Johan Andrén 2017-12-05 18:51:58 +01:00 • committed by GitHub
parent f996731c42
commit fb689baab8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 111 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

44
akka-stream-tests/src/test/scala/akka/stream/scaladsl/FlowMapAsyncSpec.scala
View file

@ -6,7 +6,7 @@ package akka.stream.scaladsl
import java.util.concurrent.{ LinkedBlockingQueue, ThreadLocalRandom }
import java.util.concurrent.atomic.AtomicInteger
import akka.stream.ActorAttributes.supervisionStrategy
import akka.stream.ActorAttributes.{ SupervisionStrategy, supervisionStrategy }
import akka.stream.{ ActorAttributes, ActorMaterializer, Supervision }
import akka.stream.Supervision.resumingDecider
import akka.stream.impl.ReactiveStreamsCompliance
@ -350,6 +350,48 @@ class FlowMapAsyncSpec extends StreamSpec {
}
}
"not invoke the decider twice for the same failed future" in {
import system.dispatcher
val failCount = new AtomicInteger(0)
val result = Source(List(true, false))
.mapAsync(1)(elem ⇒
Future {
if (elem) throw TE("this has gone too far")
else elem
}
).addAttributes(supervisionStrategy {
case TE("this has gone too far") ⇒
failCount.incrementAndGet()
Supervision.resume
case _ ⇒ Supervision.stop
})
.runWith(Sink.seq)
result.futureValue should ===(Seq(false))
failCount.get() should ===(1)
}
"not invoke the decider twice for the same failure to produce a future" in {
import system.dispatcher
val failCount = new AtomicInteger(0)
val result = Source(List(true, false))
.mapAsync(1)(elem ⇒
if (elem) throw TE("this has gone too far")
else Future {
elem
}
).addAttributes(supervisionStrategy {
case TE("this has gone too far") ⇒
failCount.incrementAndGet()
Supervision.resume
case _ ⇒ Supervision.stop
})
.runWith(Sink.seq)
result.futureValue should ===(Seq(false))
failCount.get() should ===(1)
}
}
}