raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Enable strict scalac options for akka-protobuf (#26582)

Browse source 
* Enable strict scalac options for akka-protobuf

Unfortunately it still produces a Java warning, but I see no safe way around
that (so we can't just add `-Werror` to javacOptions)

* Remove 'dead' code, bringing the class back in line with upstream
This commit is contained in:
Arnout Engelen 2019-03-27 10:26:35 +01:00 • committed by GitHub
commit fa2a89310c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
akka-protobuf/src/main/java/akka/protobuf/AbstractParser.java
View file

@ -114,10 +114,6 @@ public abstract class AbstractParser<MessageType extends MessageLite>
return message;
} catch (InvalidProtocolBufferException e) {
throw e;
} catch (IOException e) {
throw new RuntimeException(
"Reading from a ByteString threw an IOException (should " +
"never happen).", e);
}
}
@ -151,10 +147,6 @@ public abstract class AbstractParser<MessageType extends MessageLite>
return message;
} catch (InvalidProtocolBufferException e) {
throw e;
} catch (IOException e) {
throw new RuntimeException(
"Reading from a byte array threw an IOException (should " +
"never happen).", e);
}
}

2
project/AkkaDisciplinePlugin.scala
View file

@ -24,10 +24,12 @@ object AkkaDisciplinePlugin extends AutoPlugin with ScalafixSupport {
val fatalWarningsFor = Set(
"akka-discovery",
"akka-distributed-data",
"akka-protobuf",
)
val strictProjects = Set(
"akka-discovery",
"akka-protobuf",
)
lazy val scalaFixSettings = Seq(