raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

Reword the "ask versus ?" typed style docs (#27390)

Browse source
This commit is contained in:
Dale Wijnand 2019-07-23 08:25:34 +01:00 • committed by Arnout Engelen
parent fb653cc336
commit f2eec1106d
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
akka-docs/src/main/paradox/typed/style-guide.md
View file

@ -409,29 +409,28 @@ Scala
## ask versus ? ## ask versus ?
When using the `AskPattern` it's recommended to use the `ask` method rather than the `?` operator. When using the `AskPattern` it's recommended to use the `ask` method rather than the infix `?` operator, like so:
Scala Scala
: @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-1 } : @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-1 }
Instead of the `replyTo` you can use `_` for less verbosity. You may also use the more terse placeholder syntax `_` instead of `replyTo`:
Scala Scala
: @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-2 } : @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-2 }
When using `?` the following doesn't compile because of type inference problem: However, using the infix operator `?` with the placeholder syntax `_`, like is done in the following example, won't typecheck because of the binding scope rules for wildcard parameters:
Scala Scala
: @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-3 } : @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-3 }
By adding parentheses it works but is rather ugly, and therefore better to stick with `ask`. Adding the necessary parentheses (as shown below) makes it typecheck, but, subjectively, it's rather ugly so the recommendation is to use `ask`.
Scala Scala
: @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-4 } : @@snip [StyleGuideDocExamples.scala](/akka-actor-typed-tests/src/test/scala/docs/akka/typed/StyleGuideDocExamples.scala) { #ask-4 }
Note that `AskPattern` is only intended for request-response interaction from outside an actor. If the requester is Note that `AskPattern` is only intended for request-response interaction from outside an actor. If the requester is
inside an actor, prefer `ActorContext.ask` as it provides better thread-safety by not involving inside an actor, prefer `ActorContext.ask` as it provides better thread-safety by not requiring the use of a @scala[`Future`]@java[`CompletionStage`] inside the actor.
@scala[`Future`]@java[`CompletionStage`] inside the actor.
@@@ @@@