raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

!clu #3683 Change cluster heartbeat to req/rsp protocol

Browse source 
* The previous one-way hearbeat was elegant, but comlicated to
  understand and without giving much extra value compared to this approach.
* The previous one-way heartbeat have some kind of bug when joining
  several (10-20) nodes at approximately the same time (but not exactly
  the same time) with a false failure detection triggered by the extra heartbeat,
  which would not heal.
* This ping-pong approach will increase network traffic slightly, but heartbeat
  messages are small and each node is limited to monitor (default) 5 peers.
This commit is contained in:
Patrik Nordwall 2013-11-07 13:52:08 +01:00
parent 05f402c236
commit eaad7ecf7e
15 changed files with 350 additions and 439 deletions
Download patch file Download diff file Expand all files Collapse all files

35
akka-cluster/src/main/scala/akka/cluster/protobuf/ClusterMessageSerializer.scala
View file

@ -47,10 +47,8 @@ class ClusterMessageSerializer(val system: ExtendedActorSystem) extends Serializ
InternalClusterAction.InitJoin.getClass -> (_ ⇒ InternalClusterAction.InitJoin),
classOf[InternalClusterAction.InitJoinAck] -> (bytes ⇒ InternalClusterAction.InitJoinAck(addressFromBinary(bytes))),
classOf[InternalClusterAction.InitJoinNack] -> (bytes ⇒ InternalClusterAction.InitJoinNack(addressFromBinary(bytes))),
classOf[ClusterHeartbeatReceiver.Heartbeat] -> (bytes ⇒ ClusterHeartbeatReceiver.Heartbeat(addressFromBinary(bytes))),
classOf[ClusterHeartbeatReceiver.EndHeartbeat] -> (bytes ⇒ ClusterHeartbeatReceiver.EndHeartbeat(addressFromBinary(bytes))),
classOf[ClusterHeartbeatReceiver.EndHeartbeatAck] -> (bytes ⇒ ClusterHeartbeatReceiver.EndHeartbeatAck(addressFromBinary(bytes))),
classOf[ClusterHeartbeatSender.HeartbeatRequest] -> (bytes ⇒ ClusterHeartbeatSender.HeartbeatRequest(addressFromBinary(bytes))),
classOf[ClusterHeartbeatSender.Heartbeat] -> (bytes ⇒ ClusterHeartbeatSender.Heartbeat(addressFromBinary(bytes))),
classOf[ClusterHeartbeatSender.HeartbeatRsp] -> (bytes ⇒ ClusterHeartbeatSender.HeartbeatRsp(uniqueAddressFromBinary(bytes))),
classOf[GossipStatus] -> gossipStatusFromBinary,
classOf[GossipEnvelope] -> gossipEnvelopeFromBinary,
classOf[MetricsGossipEnvelope] -> metricsGossipEnvelopeFromBinary)
@ -60,20 +58,18 @@ class ClusterMessageSerializer(val system: ExtendedActorSystem) extends Serializ
def identifier = 5
def toBinary(obj: AnyRef): Array[Byte] = obj match {
case ClusterHeartbeatReceiver.Heartbeat(from) ⇒ addressToProtoByteArray(from)
case m: GossipEnvelope ⇒ gossipEnvelopeToProto(m).toByteArray
case m: GossipStatus ⇒ gossipStatusToProto(m).toByteArray
case m: MetricsGossipEnvelope ⇒ compress(metricsGossipEnvelopeToProto(m))
case InternalClusterAction.Join(node, roles) ⇒ joinToProto(node, roles).toByteArray
case InternalClusterAction.Welcome(from, gossip) ⇒ compress(welcomeToProto(from, gossip))
case ClusterUserAction.Leave(address) ⇒ addressToProtoByteArray(address)
case ClusterUserAction.Down(address) ⇒ addressToProtoByteArray(address)
case InternalClusterAction.InitJoin ⇒ cm.Empty.getDefaultInstance.toByteArray
case InternalClusterAction.InitJoinAck(address) ⇒ addressToProtoByteArray(address)
case InternalClusterAction.InitJoinNack(address) ⇒ addressToProtoByteArray(address)
case ClusterHeartbeatReceiver.EndHeartbeat(from) ⇒ addressToProtoByteArray(from)
case ClusterHeartbeatReceiver.EndHeartbeatAck(from) ⇒ addressToProtoByteArray(from)
case ClusterHeartbeatSender.HeartbeatRequest(from) ⇒ addressToProtoByteArray(from)
case ClusterHeartbeatSender.Heartbeat(from) ⇒ addressToProtoByteArray(from)
case ClusterHeartbeatSender.HeartbeatRsp(from) ⇒ uniqueAddressToProtoByteArray(from)
case m: GossipEnvelope ⇒ gossipEnvelopeToProto(m).toByteArray
case m: GossipStatus ⇒ gossipStatusToProto(m).toByteArray
case m: MetricsGossipEnvelope ⇒ compress(metricsGossipEnvelopeToProto(m))
case InternalClusterAction.Join(node, roles) ⇒ joinToProto(node, roles).toByteArray
case InternalClusterAction.Welcome(from, gossip) ⇒ compress(welcomeToProto(from, gossip))
case ClusterUserAction.Leave(address) ⇒ addressToProtoByteArray(address)
case ClusterUserAction.Down(address) ⇒ addressToProtoByteArray(address)
case InternalClusterAction.InitJoin ⇒ cm.Empty.getDefaultInstance.toByteArray
case InternalClusterAction.InitJoinAck(address) ⇒ addressToProtoByteArray(address)
case InternalClusterAction.InitJoinNack(address) ⇒ addressToProtoByteArray(address)
case _ ⇒
throw new IllegalArgumentException(s"Can't serialize object of type ${obj.getClass}")
}
@ -127,6 +123,9 @@ class ClusterMessageSerializer(val system: ExtendedActorSystem) extends Serializ
private def uniqueAddressToProto(uniqueAddress: UniqueAddress): cm.UniqueAddress.Builder =
cm.UniqueAddress.newBuilder().setAddress(addressToProto(uniqueAddress.address)).setUid(uniqueAddress.uid)
private def uniqueAddressToProtoByteArray(uniqueAddress: UniqueAddress): Array[Byte] =
uniqueAddressToProto(uniqueAddress).build.toByteArray
// we don't care about races here since it's just a cache
@volatile
private var protocolCache: String = null