diff --git a/akka-actor-tests/src/test/scala/akka/actor/dispatch/DispatchersSpec.scala b/akka-actor-tests/src/test/scala/akka/actor/dispatch/DispatchersSpec.scala index 0556a1762e..03c5f21711 100644 --- a/akka-actor-tests/src/test/scala/akka/actor/dispatch/DispatchersSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/actor/dispatch/DispatchersSpec.scala @@ -107,7 +107,7 @@ class DispatchersSpec extends AkkaSpec(DispatchersSpec.config) with ImplicitSend "include system name and dispatcher id in thread names for fork-join-executor" in { system.actorOf(Props[ThreadNameEcho].withDispatcher("myapp.mydispatcher")) ! "what's the name?" - val Expected = "(DispatchersSpec-myapp.mydispatcher-[1-9][0-9]*-worker-[1-9][0-9]*)".r + val Expected = "(DispatchersSpec-myapp.mydispatcher-[1-9][0-9]*)".r expectMsgPF(5 seconds) { case Expected(x) ⇒ } @@ -123,7 +123,7 @@ class DispatchersSpec extends AkkaSpec(DispatchersSpec.config) with ImplicitSend "include system name and dispatcher id in thread names for default-dispatcher" in { system.actorOf(Props[ThreadNameEcho]) ! "what's the name?" - val Expected = "(DispatchersSpec-akka.actor.default-dispatcher-[1-9][0-9]*-worker-[1-9][0-9]*)".r + val Expected = "(DispatchersSpec-akka.actor.default-dispatcher-[1-9][0-9]*)".r expectMsgPF(5 seconds) { case Expected(x) ⇒ } diff --git a/akka-actor/src/main/scala/akka/dispatch/AbstractDispatcher.scala b/akka-actor/src/main/scala/akka/dispatch/AbstractDispatcher.scala index cdafb37dc0..8ac5aba564 100644 --- a/akka-actor/src/main/scala/akka/dispatch/AbstractDispatcher.scala +++ b/akka-actor/src/main/scala/akka/dispatch/AbstractDispatcher.scala @@ -422,8 +422,10 @@ class ThreadPoolExecutorConfigurator(config: Config, prerequisites: DispatcherPr def createExecutorServiceFactory(id: String, threadFactory: ThreadFactory): ExecutorServiceFactory = { val tf = threadFactory match { - case m: MonitorableThreadFactory ⇒ m.copy(m.name + "-" + id) - case other ⇒ other + case m: MonitorableThreadFactory ⇒ + // add the dispatcher id to the thread names + m.copy(m.name + "-" + id) + case other ⇒ other } threadPoolConfig.createExecutorServiceFactory(id, tf) } @@ -476,8 +478,10 @@ class ForkJoinExecutorConfigurator(config: Config, prerequisites: DispatcherPrer } final def createExecutorServiceFactory(id: String, threadFactory: ThreadFactory): ExecutorServiceFactory = { val tf = threadFactory match { - case m: MonitorableThreadFactory ⇒ m.copy(m.name + "-" + id) - case other ⇒ other + case m: MonitorableThreadFactory ⇒ + // add the dispatcher id to the thread names + m.copy(m.name + "-" + id) + case other ⇒ other } new ForkJoinExecutorServiceFactory( validate(tf), diff --git a/akka-actor/src/main/scala/akka/dispatch/ThreadPoolBuilder.scala b/akka-actor/src/main/scala/akka/dispatch/ThreadPoolBuilder.scala index 4b95ab2931..1c63831013 100644 --- a/akka-actor/src/main/scala/akka/dispatch/ThreadPoolBuilder.scala +++ b/akka-actor/src/main/scala/akka/dispatch/ThreadPoolBuilder.scala @@ -173,7 +173,7 @@ case class MonitorableThreadFactory(name: String, def newThread(pool: ForkJoinPool): ForkJoinWorkerThread = { val t = wire(ForkJoinPool.defaultForkJoinWorkerThreadFactory.newThread(pool)) // Name of the threads for the ForkJoinPool are not customizable. Change it here. - if (t.getName.startsWith("ForkJoinPool-")) t.setName(name + "-" + t.getName.substring("ForkJoinPool-".length)) + t.setName(name + "-" + counter.incrementAndGet()) t } diff --git a/akka-slf4j/src/test/scala/akka/event/slf4j/Slf4jEventHandlerSpec.scala b/akka-slf4j/src/test/scala/akka/event/slf4j/Slf4jEventHandlerSpec.scala index f66a06c6ab..87d4869fef 100644 --- a/akka-slf4j/src/test/scala/akka/event/slf4j/Slf4jEventHandlerSpec.scala +++ b/akka-slf4j/src/test/scala/akka/event/slf4j/Slf4jEventHandlerSpec.scala @@ -59,7 +59,7 @@ class Slf4jEventHandlerSpec extends AkkaSpec(Slf4jEventHandlerSpec.config) with output.reset() } - val sourceThreadRegex = "sourceThread=\\[Slf4jEventHandlerSpec-akka.actor.default-dispatcher-[1-9][0-9]*-worker-[1-9][0-9]*\\]" + val sourceThreadRegex = "sourceThread=\\[Slf4jEventHandlerSpec-akka.actor.default-dispatcher-[1-9][0-9]*\\]" "Slf4jEventHandler" must {