From de7d18667f014f707cebafcb7acac8062fb9e255 Mon Sep 17 00:00:00 2001 From: yiksanchan Date: Mon, 11 May 2020 01:17:29 -0700 Subject: [PATCH] cancellable var -> private val (#29041) --- .../pr-29041-immutable-cancellable.excludes | 6 ++++++ .../src/main/scala/akka/cluster/ddata/Replicator.scala | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 akka-distributed-data/src/main/mima-filters/2.6.5.backwards.excludes/pr-29041-immutable-cancellable.excludes diff --git a/akka-distributed-data/src/main/mima-filters/2.6.5.backwards.excludes/pr-29041-immutable-cancellable.excludes b/akka-distributed-data/src/main/mima-filters/2.6.5.backwards.excludes/pr-29041-immutable-cancellable.excludes new file mode 100644 index 0000000000..ffa12fe001 --- /dev/null +++ b/akka-distributed-data/src/main/mima-filters/2.6.5.backwards.excludes/pr-29041-immutable-cancellable.excludes @@ -0,0 +1,6 @@ +# Change internal methods of the Replicator actor +ProblemFilters.exclude[DirectMissingMethodProblem]("akka.cluster.ddata.ReadWriteAggregator.sendToSecondarySchedule") +ProblemFilters.exclude[DirectMissingMethodProblem]("akka.cluster.ddata.ReadWriteAggregator.sendToSecondarySchedule_=") +ProblemFilters.exclude[DirectMissingMethodProblem]("akka.cluster.ddata.ReadWriteAggregator.timeoutSchedule") +ProblemFilters.exclude[DirectMissingMethodProblem]("akka.cluster.ddata.ReadWriteAggregator.timeoutSchedule_=") + diff --git a/akka-distributed-data/src/main/scala/akka/cluster/ddata/Replicator.scala b/akka-distributed-data/src/main/scala/akka/cluster/ddata/Replicator.scala index 21879dc47a..8cbfa04501 100644 --- a/akka-distributed-data/src/main/scala/akka/cluster/ddata/Replicator.scala +++ b/akka-distributed-data/src/main/scala/akka/cluster/ddata/Replicator.scala @@ -2369,8 +2369,8 @@ final class Replicator(settings: ReplicatorSettings) extends Actor with ActorLog def shuffle: Boolean import context.dispatcher - var sendToSecondarySchedule = context.system.scheduler.scheduleOnce(timeout / 5, self, SendToSecondary) - var timeoutSchedule = context.system.scheduler.scheduleOnce(timeout, self, ReceiveTimeout) + private val sendToSecondarySchedule = context.system.scheduler.scheduleOnce(timeout / 5, self, SendToSecondary) + private val timeoutSchedule = context.system.scheduler.scheduleOnce(timeout, self, ReceiveTimeout) var remaining = nodes.iterator.map(_.address).toSet