raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

DOC: correct wrong advice in 'Routers and Supervision', see #3484

Browse source 
* and clarify default restart behavior more
This commit is contained in:
Patrik Nordwall 2013-07-01 15:44:01 +02:00
parent 1cca2b85e3
commit dd64eabf09
2 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
akka-docs/rst/java/routing.rst
View file

@ -131,15 +131,18 @@ turn, will cause its children to stop and restart.
It should be mentioned that the router's restart behavior has been overridden so that a restart, It should be mentioned that the router's restart behavior has been overridden so that a restart,
while still re-creating the children, will still preserve the same number of actors in the pool. while still re-creating the children, will still preserve the same number of actors in the pool.
This means that if you have not specified :meth:`supervisorStrategy` of the router or its parent a
failure in a routee will escalate to the parent of the router, which will by default restart the router,
which will restart all routees (it uses Escalate and does not stop routees during restart). The reason
is to make the default behave such that adding :meth:`.withRouter` to a child’s definition does not
change the supervision strategy applied to the child. This might be an inefficiency that you can avoid
by specifying the strategy when defining the router.
Setting the strategy is easily done: Setting the strategy is easily done:
.. includecode:: code/docs/jrouting/CustomRouterDocTest.java .. includecode:: code/docs/jrouting/CustomRouterDocTest.java
:include: supervision :include: supervision
Another potentially useful approach is to give the router the same strategy as
its parent, which effectively treats all actors in the pool as if they were
direct children of their grand-parent instead.
.. _note-router-terminated-children-java: .. _note-router-terminated-children-java:
.. note:: .. note::

11
akka-docs/rst/scala/routing.rst
View file

@ -132,16 +132,19 @@ turn, will cause its children to stop and restart.
It should be mentioned that the router's restart behavior has been overridden so that a restart, It should be mentioned that the router's restart behavior has been overridden so that a restart,
while still re-creating the children, will still preserve the same number of actors in the pool. while still re-creating the children, will still preserve the same number of actors in the pool.
This means that if you have not specified :meth:`supervisorStrategy` of the router or its parent a
failure in a routee will escalate to the parent of the router, which will by default restart the router,
which will restart all routees (it uses Escalate and does not stop routees during restart). The reason
is to make the default behave such that adding :meth:`.withRouter` to a child’s definition does not
change the supervision strategy applied to the child. This might be an inefficiency that you can avoid
by specifying the strategy when defining the router.
Setting the strategy is easily done: Setting the strategy is easily done:
.. includecode:: ../../../akka-actor-tests/src/test/scala/akka/routing/RoutingSpec.scala#supervision .. includecode:: ../../../akka-actor-tests/src/test/scala/akka/routing/RoutingSpec.scala#supervision
:include: supervision :include: supervision
:exclude: custom-strategy :exclude: custom-strategy
Another potentially useful approach is to give the router the same strategy as
its parent, which effectively treats all actors in the pool as if they were
direct children of their grand-parent instead.
.. _note-router-terminated-children-scala: .. _note-router-terminated-children-scala:
.. note:: .. note::