raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

=doc missing ACK reply in doc example (#24997)

Browse source
This commit is contained in:
Konrad `ktoso` Malawski 2018-04-30 21:12:04 +09:00 • committed by Arnout Engelen
parent 3e11092388
commit d870d37bb3
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
akka-docs/src/test/java/jdocs/stream/IntegrationDocTest.java
View file

@ -329,6 +329,7 @@ public class IntegrationDocTest extends AbstractJavaTest {
return receiveBuilder()
.match(StreamInitialized.class, init -> {
log().info("Stream initialized");
sender().tell(new Ack(), self());
})
.match(String.class, element -> {
log().info("Received element: {}", element);

13
akka-docs/src/test/scala/docs/stream/IntegrationDocSpec.scala
View file

@ -210,8 +210,9 @@ class IntegrationDocSpec extends AkkaSpec(IntegrationDocSpec.config) {
val OnCompleteMessage = AckingReceiver.StreamCompleted
val onErrorMessage = (ex: Throwable) ⇒ AckingReceiver.StreamFailure(ex)
val probe = TestProbe()
val receiver = system.actorOf(
Props(new AckingReceiver(ackWith = AckMessage)))
Props(new AckingReceiver(probe.ref, ackWith = AckMessage)))
val sink = Sink.actorRefWithAck(
receiver,
onInitMessage = InitMessage,
@ -224,6 +225,10 @@ class IntegrationDocSpec extends AkkaSpec(IntegrationDocSpec.config) {
.map(_.toLowerCase)
.runWith(sink)
//#actorRefWithAck
probe.expectMsg("Stream initialized!")
probe.expectMsg("hello")
probe.expectMsg("hi")
probe.expectMsg("Stream completed!")
}
//#actorRefWithAck-actor
@ -235,19 +240,23 @@ class IntegrationDocSpec extends AkkaSpec(IntegrationDocSpec.config) {
final case class StreamFailure(ex: Throwable)
}
class AckingReceiver(ackWith: Any) extends Actor with ActorLogging {
class AckingReceiver(probe: ActorRef, ackWith: Any) extends Actor with ActorLogging {
import AckingReceiver._
def receive: Receive = {
case StreamInitialized ⇒
log.info("Stream initialized!")
probe ! "Stream initialized!"
sender() ! Ack // ack to allow the stream to proceed sending more elements
case el: String ⇒
log.info("Received element: {}", el)
probe ! el
sender() ! Ack // ack to allow the stream to proceed sending more elements
case StreamCompleted ⇒
log.info("Stream completed!")
probe ! "Stream completed!"
case StreamFailure(ex) ⇒
log.error(ex, "Stream failed!")
}