raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

check reference equality when registering a persistent datastructure, and fail if one is already there with a different reference

Browse source
This commit is contained in:
ticktock 2010-11-19 09:29:36 -05:00
parent 12b50a623e
commit d2ed29ef37
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
akka-stm/src/main/scala/stm/Transaction.scala
View file

@ -112,7 +112,10 @@ object Transaction {
def commit = synchronized {
log.trace("Committing transaction " + toString)
retry(STATE_RETRIES){persistentStateMap.valuesIterator.foreach(_.commit)}
retry(STATE_RETRIES){
persistentStateMap.valuesIterator.foreach(_.commit)
persistentStateMap.clear
}
status = TransactionStatus.Completed
jta.foreach(_.commit)
}
@ -160,7 +163,13 @@ object Transaction {
private[akka] def isTopLevel = depth.get == 0
//when calling this method, make sure to prefix the uuid with the type so you
//have no possibility of kicking a diffferent type with the same uuid out of a transction
private[akka] def register(uuid: String, storage: Committable with Abortable) = persistentStateMap.put(uuid, storage)
private[akka] def register(uuid: String, storage: Committable with Abortable) = {
if(persistentStateMap.getOrElseUpdate(uuid, {storage}) ne storage){
log.error("existing:"+System.identityHashCode(persistentStateMap.get(uuid).get))
log.error("new:"+System.identityHashCode(storage))
throw new IllegalStateException("attempted to register an instance of persistent data structure for id [%s] when there is already a different instance registered".format(uuid))
}
}
private def ensureIsActive = if (status != TransactionStatus.Active)
throw new StmConfigurationException(