From d2ce939db49fda4c2264bde372e93ddc843b526c Mon Sep 17 00:00:00 2001 From: Patrik Nordwall Date: Wed, 5 Dec 2012 09:32:10 +0100 Subject: [PATCH] Adjust backoffThreshold in ResizerSpec, see #2763 * When it failed the backoff calculation was often based on pressure=1 and capacity=4, 1/4=0.25 which is greater than the backoffThreshold=0.2, i.e no backoff was done. * Changed backoffThreshold to 0.4. * Avoid sleep inside the target actor when cool down --- .../src/test/scala/akka/routing/ResizerSpec.scala | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/akka-actor-tests/src/test/scala/akka/routing/ResizerSpec.scala b/akka-actor-tests/src/test/scala/akka/routing/ResizerSpec.scala index 5f3d2bdce1..b2eeccf3bf 100644 --- a/akka-actor-tests/src/test/scala/akka/routing/ResizerSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/routing/ResizerSpec.scala @@ -180,13 +180,14 @@ class ResizerSpec extends AkkaSpec(ResizerSpec.config) with DefaultTimeout with upperBound = 5, rampupRate = 1.0, backoffRate = 1.0, - backoffThreshold = 0.20, + backoffThreshold = 0.40, pressureThreshold = 1, messagesPerResize = 1) val router = system.actorOf(Props(new Actor { def receive = { - case n: Int ⇒ Thread.sleep((n millis).dilated.toMillis) + case n: Int if n <= 0 ⇒ // done + case n: Int ⇒ Thread.sleep((n millis).dilated.toMillis) } }).withRouter(RoundRobinRouter(resizer = Some(resizer)))) @@ -203,7 +204,7 @@ class ResizerSpec extends AkkaSpec(ResizerSpec.config) with DefaultTimeout with // let it cool down awaitCond({ - router ! 1 // trigger resize + router ! 0 // trigger resize routeeSize(router) < z }, interval = 500.millis.dilated)