From 35f2255e64b32ca756d86905ba804d4df7c8a50e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20S=C3=A1ndor=20Varga?= Date: Fri, 12 Apr 2013 15:52:39 +0200 Subject: [PATCH 1/2] The test implicitly relied on a loss of a message --- akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala b/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala index 8b14918c79..463d28fe55 100644 --- a/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala @@ -408,7 +408,6 @@ class SupervisorSpec extends AkkaSpec with BeforeAndAfterEach with ImplicitSende val latch = TestLatch() parent ! latch - parent ! "testchild" EventFilter[IllegalStateException]("OHNOES", occurrences = 1) intercept { latch.countDown() } From 48cd640772bd367429f875c1c3f818213406fa4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20S=C3=A1ndor=20Varga?= Date: Fri, 12 Apr 2013 16:32:43 +0200 Subject: [PATCH 2/2] The test implicitly relied on a loss of a message - test now ensures that the message is lost --- .../src/test/scala/akka/actor/SupervisorSpec.scala | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala b/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala index 463d28fe55..cf576bea63 100644 --- a/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/actor/SupervisorSpec.scala @@ -403,14 +403,19 @@ class SupervisorSpec extends AkkaSpec with BeforeAndAfterEach with ImplicitSende case l: TestLatch ⇒ child ! l case "test" ⇒ sender ! "green" case "testchild" ⇒ child forward "test" + case "testchildAndAck" ⇒ child forward "test"; sender ! "ack" } })) val latch = TestLatch() parent ! latch - EventFilter[IllegalStateException]("OHNOES", occurrences = 1) intercept { - latch.countDown() - } + parent ! "testchildAndAck" + expectMsg("ack") + filterEvents( + EventFilter[IllegalStateException]("OHNOES", occurrences = 1), + EventFilter.warning(pattern = "dead.*test", occurrences = 1)) { + latch.countDown() + } expectMsg("parent restarted") expectMsg("child terminated") parent ! "test"