raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Avoid 'dead code after this construct' warnings in jackson-databind example (#29278)

Browse source 
This signature of jackson-databind's `set` is:

    public <T extends JsonNode> T set(String fieldName, JsonNode value)

When running the Scala compiler with dead code warnings enabled, this
will cause warnings due to https://github.com/scala/bug/issues/8109 .
Making the generic type explicit avoids that.
This commit is contained in:
Arnout Engelen 2020-06-23 09:15:17 +02:00 • committed by GitHub
parent d6fd8c30e0
commit ce07d5f15a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
akka-serialization-jackson/src/test/scala/akka/serialization/jackson/JacksonSerializerSpec.scala
View file

@ -125,9 +125,9 @@ class ScalaTestEventMigration extends JacksonMigration {
override def transform(fromVersion: Int, json: JsonNode): JsonNode = {
val root = json.asInstanceOf[ObjectNode]
root.set("field1V2", root.get("field1"))
root.set[JsonNode]("field1V2", root.get("field1"))
root.remove("field1")
root.set("field2", IntNode.valueOf(17))
root.set[JsonNode]("field2", IntNode.valueOf(17))
root
}
}

8
akka-serialization-jackson/src/test/scala/doc/akka/serialization/jackson/v2a/CustomerMigration.scala
View file

@ -17,10 +17,10 @@ class CustomerMigration extends JacksonMigration {
val root = json.asInstanceOf[ObjectNode]
if (fromVersion <= 1) {
val shippingAddress = root.`with`("shippingAddress")
shippingAddress.set("street", root.get("street"))
shippingAddress.set("city", root.get("city"))
shippingAddress.set("zipCode", root.get("zipCode"))
shippingAddress.set("country", root.get("country"))
shippingAddress.set[JsonNode]("street", root.get("street"))
shippingAddress.set[JsonNode]("city", root.get("city"))
shippingAddress.set[JsonNode]("zipCode", root.get("zipCode"))
shippingAddress.set[JsonNode]("country", root.get("country"))
root.remove("street")
root.remove("city")
root.remove("zipCode")

2
akka-serialization-jackson/src/test/scala/doc/akka/serialization/jackson/v2c/ItemAddedMigration.scala
View file

@ -16,7 +16,7 @@ class ItemAddedMigration extends JacksonMigration {
override def transform(fromVersion: Int, json: JsonNode): JsonNode = {
val root = json.asInstanceOf[ObjectNode]
if (fromVersion <= 1) {
root.set("itemId", root.get("productId"))
root.set[JsonNode]("itemId", root.get("productId"))
root.remove("productId")
}
root