raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

Fix record overflow race condition in flight recorder #21992

Browse source 
The flag used to show a record is dirty/commited was overwritten by the
last 4 bytes of the previous metadata. Most of the time this isn't
caught as the record is written fixed width and typically the last bytes
are 0s which is the same as the Commited flag. However under
concurrency this can overwrite the Dirty flag that is preventing
corruption.
This commit is contained in:
Christopher Batey 2018-01-04 12:37:16 +00:00 • committed by Johan Andrén
parent 37f0da17b7
commit c7cbebb534
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
akka-remote/src/test/scala/akka/remote/artery/FlightRecorderSpec.scala
View file

@ -358,10 +358,10 @@ class FlightRecorderSpec extends AkkaSpec {
channel.force(false)
reader.rereadStructure()
reader.structure.loFreqLog.logs(0).richEntries.size should ===(FlightRecorder.LoFreqWindow)
reader.structure.loFreqLog.logs.head.richEntries.size should ===(FlightRecorder.LoFreqWindow)
for (i ← 1 to Threads) {
val entries = reader.structure.loFreqLog.logs(0).richEntries.filter(_.code == i).toSeq
val entries = reader.structure.loFreqLog.logs.head.richEntries.filter(_.code == i).toSeq
entries.exists(_.dirty) should be(false)
// Entries are consecutive for any given writer