From c686622acf190867498a21b25001fd9b366fc20c Mon Sep 17 00:00:00 2001 From: Viktor Klang Date: Wed, 6 Jun 2012 14:23:34 +0200 Subject: [PATCH] Deciding not to publish errors when a message delivery fails --- akka-remote/src/main/scala/akka/remote/netty/Client.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/akka-remote/src/main/scala/akka/remote/netty/Client.scala b/akka-remote/src/main/scala/akka/remote/netty/Client.scala index 2d3748fb52..c9e78902f4 100644 --- a/akka-remote/src/main/scala/akka/remote/netty/Client.scala +++ b/akka-remote/src/main/scala/akka/remote/netty/Client.scala @@ -65,8 +65,8 @@ private[akka] abstract class RemoteClient private[akka] (val netty: NettyRemoteT new ChannelFutureListener { def operationComplete(future: ChannelFuture) { if (future.isCancelled || !future.isSuccess) { - //FIXME Should we just _not_ notifyListeners here and just assume that the other error reporting is sufficient? - netty.notifyListeners(RemoteClientError(future.getCause, netty, remoteAddress)) + // We don't call notifyListeners here since we don't think failed message deliveries are errors + // If the connection goes down we'll get the error reporting done by the pipeline. val (message, sender, recipient) = request netty.system.deadLetters ! DeadLetter(message, sender.getOrElse(netty.system.deadLetters), recipient) }