From bc9bd679a74259974df77d4fafe48d0cef00b35c Mon Sep 17 00:00:00 2001 From: He-Pin Date: Sun, 24 Sep 2023 23:07:00 +0800 Subject: [PATCH] =act Make parameter rename safe. --- .../actor/typed/internal/routing/PoolRouterImpl.scala | 7 ++++--- .../org/apache/pekko/actor/typed/javadsl/Routers.scala | 4 +++- .../org/apache/pekko/actor/typed/scaladsl/Routers.scala | 6 +++++- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/routing/PoolRouterImpl.scala b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/routing/PoolRouterImpl.scala index 6ce6593ff3..8789052ad6 100644 --- a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/routing/PoolRouterImpl.scala +++ b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/routing/PoolRouterImpl.scala @@ -63,10 +63,11 @@ private[pekko] final case class PoolRouterBuilder[T]( def withRouteeProps(routeeProps: Props): PoolRouterBuilder[T] = copy(routeeProps = routeeProps) - override def withBroadcastPredicate(pred: Predicate[T]): PoolRouter[T] = - copy(broadcastPredicate = value => pred.test(value)) + override def withBroadcastPredicate(predicate: Predicate[T]): PoolRouter[T] = + copy(broadcastPredicate = value => predicate.test(value)) - override def withBroadcastPredicate(pred: T => Boolean): scaladsl.PoolRouter[T] = copy(broadcastPredicate = pred) + override def withBroadcastPredicate(predicate: T => Boolean): scaladsl.PoolRouter[T] = + copy(broadcastPredicate = predicate) } /** diff --git a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/javadsl/Routers.scala b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/javadsl/Routers.scala index 272bf70ab0..8cb969e004 100644 --- a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/javadsl/Routers.scala +++ b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/javadsl/Routers.scala @@ -21,6 +21,7 @@ import pekko.actor.typed.receptionist.ServiceKey import pekko.annotation.DoNotInherit import java.util.function.Predicate +import scala.annotation.nowarn object Routers { @@ -197,5 +198,6 @@ abstract class PoolRouter[T] extends DeferredBehavior[T] { /** * Any message that the predicate returns true for will be broadcast to all routees. */ - def withBroadcastPredicate(pred: Predicate[T]): PoolRouter[T] + @nowarn("msg=deprecated") + def withBroadcastPredicate(@deprecatedName(Symbol("pred")) predicate: Predicate[T]): PoolRouter[T] } diff --git a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/scaladsl/Routers.scala b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/scaladsl/Routers.scala index ddc2d8ade1..6cd23279c9 100644 --- a/actor-typed/src/main/scala/org/apache/pekko/actor/typed/scaladsl/Routers.scala +++ b/actor-typed/src/main/scala/org/apache/pekko/actor/typed/scaladsl/Routers.scala @@ -12,12 +12,15 @@ */ package org.apache.pekko.actor.typed.scaladsl + import org.apache.pekko import pekko.actor.typed.{ Behavior, Props } import pekko.actor.typed.internal.routing.{ GroupRouterBuilder, PoolRouterBuilder } import pekko.actor.typed.receptionist.ServiceKey import pekko.annotation.DoNotInherit +import scala.annotation.nowarn + object Routers { /** @@ -185,5 +188,6 @@ trait PoolRouter[T] extends Behavior[T] { /** * Any message that the predicate returns true for will be broadcast to all routees. */ - def withBroadcastPredicate(predicate: T => Boolean): PoolRouter[T] + @nowarn("msg=deprecated") + def withBroadcastPredicate(@deprecatedName(Symbol("pred")) predicate: T => Boolean): PoolRouter[T] }