From bb99bdb02f4f2c06a08204326264778efe0e6559 Mon Sep 17 00:00:00 2001 From: Patrik Nordwall Date: Mon, 25 Nov 2019 17:06:27 +0100 Subject: [PATCH] fix race condition in WriteAggregatorSpec, #25581 (#28242) * sometimes failed: "WriteAggregator with delta must timeout when less than required acks" * the DeltaNack will trigger immedediate send of Write * seems to be a race condition of when the probe is receiving the Write from the DeltaNack vs the last expected DeltaPropagation --- .../test/scala/akka/cluster/ddata/WriteAggregatorSpec.scala | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/akka-distributed-data/src/test/scala/akka/cluster/ddata/WriteAggregatorSpec.scala b/akka-distributed-data/src/test/scala/akka/cluster/ddata/WriteAggregatorSpec.scala index db5b2ab959..2b48e89543 100644 --- a/akka-distributed-data/src/test/scala/akka/cluster/ddata/WriteAggregatorSpec.scala +++ b/akka-distributed-data/src/test/scala/akka/cluster/ddata/WriteAggregatorSpec.scala @@ -354,9 +354,12 @@ class WriteAggregatorSpec extends AkkaSpec(s""" probe.expectMsgType[DeltaPropagation] probe.lastSender ! WriteAck probe.expectMsgType[DeltaPropagation] + // no reply + probe.expectMsgType[DeltaPropagation] // nack probe.lastSender ! DeltaNack - probe.expectMsgType[DeltaPropagation] + // the nack will triggger an immediate Write + probe.expectMsgType[Write] // no reply // only 1 ack so we expect 3 full state Write