raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

harden access to outboundControlIngress, #27732 (#27834)

Browse source 
* _outboundControlIngress is cleared from removedAfterQuarantined via the
  startRemoveQuarantinedAssociationTask
* in sendControl it is checking isRemovedAfterQuarantined but a race condition
  of the clearing at the same time can cause it to access the outboundControlIngress
  anyway, resulting in the IllegalStateException "not initialized yet"
* in the reported case there were severe jvm problems (seen in logs as delayed heartbeats)
* additional check in outboundControlIngress access solves that,
  control messages can be dropped
This commit is contained in:
Patrik Nordwall 2019-10-09 14:00:03 +02:00 • committed by Johan Andrén
parent 0236afc039
commit a9d1572999
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
akka-remote/src/main/scala/akka/remote/artery/Association.scala
View file

@ -232,8 +232,8 @@ private[remote] class Association(
_outboundControlIngress match {
case OptionVal.Some(o) => o
case OptionVal.None =>
if (transport.isShutdown) throw ShuttingDown
else throw new IllegalStateException("outboundControlIngress not initialized yet")
if (transport.isShutdown || isRemovedAfterQuarantined()) throw ShuttingDown
else throw new IllegalStateException(s"outboundControlIngress for [$remoteAddress] not initialized yet")
}
}
}