raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=act #3572 Add parens to sender

Browse source 
* because it is not referentially transparent; normally we reserved parens for
  side-effecting code but given how people thoughtlessly close over it we revised
  that that decision for sender
* caller can still omit parens
This commit is contained in:
Patrik Nordwall 2014-01-16 15:16:35 +01:00
parent 537840bd2a
commit a11fb1dafc
202 changed files with 631 additions and 620 deletions
Download patch file Download diff file Expand all files Collapse all files

12
akka-remote/src/main/scala/akka/remote/Endpoint.scala
View file

@ -57,7 +57,7 @@ private[remote] class DefaultMessageDispatcher(private val system: ExtendedActor
val sender: ActorRef = senderOption.getOrElse(system.deadLetters)
val originalReceiver = recipient.path
def msgLog = s"RemoteMessage: [$payload] to [$recipient]<+[$originalReceiver] from [$sender]"
def msgLog = s"RemoteMessage: [$payload] to [$recipient]<+[$originalReceiver] from [$sender()]"
recipient match {
@ -328,7 +328,7 @@ private[remote] class ReliableDeliverySupervisor(
case s @ Send(msg: SystemMessage, _, _, _) ⇒ tryBuffer(s.copy(seqOpt = Some(nextSeq())))
case s: Send ⇒ context.system.deadLetters ! s
case EndpointWriter.FlushAndStop ⇒ context.stop(self)
case EndpointWriter.StopReading(w) ⇒ sender ! EndpointWriter.StoppedReading(w)
case EndpointWriter.StopReading(w) ⇒ sender() ! EndpointWriter.StoppedReading(w)
case _ ⇒ // Ignore
}
@ -343,7 +343,7 @@ private[remote] class ReliableDeliverySupervisor(
// Resending will be triggered by the incoming GotUid message after the connection finished
context.become(receive)
case EndpointWriter.FlushAndStop ⇒ context.stop(self)
case EndpointWriter.StopReading(w) ⇒ sender ! EndpointWriter.StoppedReading(w)
case EndpointWriter.StopReading(w) ⇒ sender() ! EndpointWriter.StoppedReading(w)
}
def flushWait: Receive = {
@ -649,7 +649,7 @@ private[remote] class EndpointWriter(
// Shutdown old reader
handle foreach { _.disassociate() }
handle = Some(newHandle)
sender ! TookOver(self, newHandle)
sender() ! TookOver(self, newHandle)
goto(Handoff)
case Event(FlushAndStop, _) ⇒
stopReason = AssociationHandle.Shutdown
@ -805,7 +805,7 @@ private[remote] class EndpointReader(
case StopReading(writer) ⇒
saveState()
context.become(notReading)
sender ! StoppedReading(writer)
sender() ! StoppedReading(writer)
}
@ -813,7 +813,7 @@ private[remote] class EndpointReader(
case Disassociated(info) ⇒ handleDisassociated(info)
case StopReading(writer) ⇒
sender ! StoppedReading(writer)
sender() ! StoppedReading(writer)
case InboundPayload(p) ⇒
val (ackOption, _) = tryDecodeMessageAndAck(p)