raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=act #3572 Add parens to sender

Browse source 
* because it is not referentially transparent; normally we reserved parens for
  side-effecting code but given how people thoughtlessly close over it we revised
  that that decision for sender
* caller can still omit parens
This commit is contained in:
Patrik Nordwall 2014-01-16 15:16:35 +01:00
parent 537840bd2a
commit a11fb1dafc
202 changed files with 631 additions and 620 deletions
Download patch file Download diff file Expand all files Collapse all files

32
akka-contrib/src/multi-jvm/scala/akka/contrib/pattern/ClusterSingletonManagerSpec.scala
View file

@ -73,33 +73,33 @@ object ClusterSingletonManagerSpec extends MultiNodeConfig {
def idle: Receive = {
case RegisterConsumer ⇒
log.info("RegisterConsumer: [{}]", sender.path)
sender ! RegistrationOk
context.become(active(sender))
log.info("RegisterConsumer: [{}]", sender().path)
sender() ! RegistrationOk
context.become(active(sender()))
case UnregisterConsumer ⇒
log.info("UnexpectedUnregistration: [{}]", sender.path)
sender ! UnexpectedUnregistration
log.info("UnexpectedUnregistration: [{}]", sender().path)
sender() ! UnexpectedUnregistration
context stop self
case Reset ⇒ sender ! ResetOk
case Reset ⇒ sender() ! ResetOk
case msg ⇒ // no consumer, drop
}
def active(consumer: ActorRef): Receive = {
case UnregisterConsumer if sender == consumer ⇒
log.info("UnregistrationOk: [{}]", sender.path)
sender ! UnregistrationOk
case UnregisterConsumer if sender() == consumer ⇒
log.info("UnregistrationOk: [{}]", sender().path)
sender() ! UnregistrationOk
context.become(idle)
case UnregisterConsumer ⇒
log.info("UnexpectedUnregistration: [{}], expected [{}]", sender.path, consumer.path)
sender ! UnexpectedUnregistration
log.info("UnexpectedUnregistration: [{}], expected [{}]", sender().path, consumer.path)
sender() ! UnexpectedUnregistration
context stop self
case RegisterConsumer ⇒
log.info("Unexpected RegisterConsumer [{}], active consumer [{}]", sender.path, consumer.path)
sender ! UnexpectedRegistration
log.info("Unexpected RegisterConsumer [{}], active consumer [{}]", sender().path, consumer.path)
sender() ! UnexpectedRegistration
context stop self
case Reset ⇒
context.become(idle)
sender ! ResetOk
sender() ! ResetOk
case msg ⇒ consumer ! msg
}
}
@ -129,7 +129,7 @@ object ClusterSingletonManagerSpec extends MultiNodeConfig {
case x @ (RegistrationOk | UnexpectedRegistration) ⇒
delegateTo ! x
case GetCurrent ⇒
sender ! current
sender() ! current
//#consumer-end
case End ⇒
queue ! UnregisterConsumer
@ -161,7 +161,7 @@ object ClusterSingletonManagerSpec extends MultiNodeConfig {
m.status == MemberStatus.Up && m.hasRole(role))
case MemberUp(m) ⇒ if (m.hasRole(role)) membersByAge += m
case MemberRemoved(m, _) ⇒ if (m.hasRole(role)) membersByAge -= m
case other ⇒ consumer foreach { _.tell(other, sender) }
case other ⇒ consumer foreach { _.tell(other, sender()) }
}
def consumer: Option[ActorSelection] =