From a0e79a0542dc0fc98bf8431a1cfd1a454f45b282 Mon Sep 17 00:00:00 2001 From: Christopher Batey Date: Mon, 6 Aug 2018 10:17:58 +0100 Subject: [PATCH] Log exception for association failure (#25438) There have been cases where the thrown NettyTransportExceptionNoStackTrace contains no cause and a message that doesn't indicate what type of exception has been thrown when establishing a connection. --- .../scala/akka/remote/transport/netty/NettyTransport.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala b/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala index c546a6afdb..414e0665e8 100644 --- a/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala +++ b/akka-remote/src/main/scala/akka/remote/transport/netty/NettyTransport.scala @@ -527,7 +527,7 @@ class NettyTransport(val settings: NettyTransportSettings, val system: ExtendedA else readyChannel.getPipeline.get(classOf[ClientHandler]).statusFuture } yield handle) recover { - case c: CancellationException ⇒ throw new NettyTransportExceptionNoStack("Connection was cancelled") + case _: CancellationException ⇒ throw new NettyTransportExceptionNoStack("Connection was cancelled") case NonFatal(t) ⇒ val msg = if (t.getCause == null) @@ -536,7 +536,7 @@ class NettyTransport(val settings: NettyTransportSettings, val system: ExtendedA s"${t.getMessage}, caused by: ${t.getCause}" else s"${t.getMessage}, caused by: ${t.getCause}, caused by: ${t.getCause.getCause}" - throw new NettyTransportExceptionNoStack(msg, t.getCause) + throw new NettyTransportExceptionNoStack(s"${t.getClass.getName}: $msg", t.getCause) } } }