From 9e54e4695be294f19fd677da54c50f93bc533331 Mon Sep 17 00:00:00 2001 From: injae kim Date: Sat, 30 Mar 2024 21:20:31 +0900 Subject: [PATCH] Fix mustBeAbleToUseMapWithAutoCloseableResource broken test (#1241) Closes #1229. --- .../test/java/org/apache/pekko/stream/javadsl/FlowTest.java | 6 ++++-- .../java/org/apache/pekko/stream/javadsl/SourceTest.java | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java index 4110cf61ee..f2e92c8863 100644 --- a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java +++ b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java @@ -239,7 +239,7 @@ public class FlowTest extends StreamTest { } @Test - public void mustBeAbleToUseMapWithAutoCloseableResource() { + public void mustBeAbleToUseMapWithAutoCloseableResource() throws Exception { final TestKit probe = new TestKit(system); final AtomicInteger closed = new AtomicInteger(); Source.from(Arrays.asList("1", "2", "3")) @@ -247,7 +247,9 @@ public class FlowTest extends StreamTest { Flow.of(String.class) .mapWithResource( () -> (AutoCloseable) closed::incrementAndGet, (resource, elem) -> elem)) - .runWith(Sink.foreach(elem -> probe.getRef().tell(elem, ActorRef.noSender())), system); + .runWith(Sink.foreach(elem -> probe.getRef().tell(elem, ActorRef.noSender())), system) + .toCompletableFuture() + .get(3, TimeUnit.SECONDS); probe.expectMsgAllOf("1", "2", "3"); Assert.assertEquals(closed.get(), 1); diff --git a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java index b44a21d9de..6fb73453ca 100644 --- a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java +++ b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java @@ -817,12 +817,14 @@ public class SourceTest extends StreamTest { } @Test - public void mustBeAbleToUseMapWithAutoCloseableResource() { + public void mustBeAbleToUseMapWithAutoCloseableResource() throws Exception { final TestKit probe = new TestKit(system); final AtomicInteger closed = new AtomicInteger(); Source.from(Arrays.asList("1", "2", "3")) .mapWithResource(() -> (AutoCloseable) closed::incrementAndGet, (resource, elem) -> elem) - .runWith(Sink.foreach(elem -> probe.getRef().tell(elem, ActorRef.noSender())), system); + .runWith(Sink.foreach(elem -> probe.getRef().tell(elem, ActorRef.noSender())), system) + .toCompletableFuture() + .get(3, TimeUnit.SECONDS); probe.expectMsgAllOf("1", "2", "3"); Assert.assertEquals(closed.get(), 1);