raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

disambiguate serializer in typed ClusterShardingSpec, #23993 (#23999)

Browse source 
* test was not always using serialization because it was just one
  entity which could be local or remote
* the test serializer was wrong
* multiple serializers found so was using java serializer
This commit is contained in:
Patrik Nordwall 2017-11-15 14:02:18 +01:00 • committed by Christopher Batey
parent f92e1c16e7
commit 9e506b25b7
1 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

26
akka-typed-tests/src/test/scala/akka/typed/cluster/sharding/ClusterShardingSpec.scala
View file

@ -60,7 +60,7 @@ object ClusterShardingSpec {
final case class WhoAreYou(replyTo: ActorRef[String]) extends TestProtocol final case class WhoAreYou(replyTo: ActorRef[String]) extends TestProtocol
final case class StopPlz() extends TestProtocol final case class StopPlz() extends TestProtocol
sealed trait IdTestProtocol { def id: String } sealed trait IdTestProtocol extends java.io.Serializable { def id: String }
final case class IdReplyPlz(id: String, toMe: ActorRef[String]) extends IdTestProtocol final case class IdReplyPlz(id: String, toMe: ActorRef[String]) extends IdTestProtocol
final case class IdWhoAreYou(id: String, replyTo: ActorRef[String]) extends IdTestProtocol final case class IdWhoAreYou(id: String, replyTo: ActorRef[String]) extends IdTestProtocol
final case class IdStopPlz(id: String) extends IdTestProtocol final case class IdStopPlz(id: String) extends IdTestProtocol
@ -100,7 +100,7 @@ object ClusterShardingSpec {
private def idAndRefFromBinary[T](bytes: Array[Byte]): (String, ActorRef[T]) = { private def idAndRefFromBinary[T](bytes: Array[Byte]): (String, ActorRef[T]) = {
val idLength = bytes(0) val idLength = bytes(0)
val id = new String(bytes.slice(1, idLength), StandardCharsets.UTF_8) val id = new String(bytes.slice(1, idLength + 1), StandardCharsets.UTF_8)
val ref = actorRefFromBinary(bytes.drop(1 + idLength)) val ref = actorRefFromBinary(bytes.drop(1 + idLength))
(id, ref) (id, ref)
} }
@ -197,11 +197,12 @@ class ClusterShardingSpec extends TypedSpec(ClusterShardingSpec.config) with Sca
10, 10,
StopPlz()) StopPlz())
val p = TestProbe[String]() (1 to 10).foreach { n ⇒
ref ! ShardingEnvelope("test", ReplyPlz(p.ref)) val p = TestProbe[String]()
p.expectMsg(3.seconds, "Hello!") ref ! ShardingEnvelope(s"test$n", ReplyPlz(p.ref))
p.expectMsg(3.seconds, "Hello!")
ref ! ShardingEnvelope("test", StopPlz()) ref ! ShardingEnvelope(s"test$n", StopPlz())
}
} }
def `03 must send messsages via cluster sharding, without envelopes`(): Unit = { def `03 must send messsages via cluster sharding, without envelopes`(): Unit = {
val ref = sharding.spawn( val ref = sharding.spawn(
@ -219,11 +220,12 @@ class ClusterShardingSpec extends TypedSpec(ClusterShardingSpec.config) with Sca
ShardingMessageExtractor.noEnvelope[IdTestProtocol](10, _.id), ShardingMessageExtractor.noEnvelope[IdTestProtocol](10, _.id),
IdStopPlz("THE_ID_HERE")) IdStopPlz("THE_ID_HERE"))
val p = TestProbe[String]() (1 to 10).foreach { n ⇒
ref ! IdReplyPlz("test", p.ref) val p = TestProbe[String]()
p.expectMsg(3.seconds, "Hello!") ref ! IdReplyPlz(s"test$n", p.ref)
p.expectMsg(3.seconds, "Hello!")
ref ! IdStopPlz("test") ref ! IdStopPlz(s"test$n")
}
} }
// def `04 fail if starting sharding for already used typeName, but with wrong type`(): Unit = { // def `04 fail if starting sharding for already used typeName, but with wrong type`(): Unit = {