From ac30175b84c1dbd12cfb9c710c4b9e7761aeb3ea Mon Sep 17 00:00:00 2001 From: Patrik Nordwall Date: Mon, 17 Dec 2012 15:31:30 +0100 Subject: [PATCH] Remove check of heap max value, see #2793 --- .../test/scala/akka/cluster/MetricValuesSpec.scala | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/akka-cluster/src/test/scala/akka/cluster/MetricValuesSpec.scala b/akka-cluster/src/test/scala/akka/cluster/MetricValuesSpec.scala index 8a38b59da6..4c10b176e6 100644 --- a/akka-cluster/src/test/scala/akka/cluster/MetricValuesSpec.scala +++ b/akka-cluster/src/test/scala/akka/cluster/MetricValuesSpec.scala @@ -37,17 +37,14 @@ class MetricValuesSpec extends AkkaSpec(MetricsEnabledSpec.config) with MetricsC "extract expected MetricValue types for load balancing" in { nodes foreach { node ⇒ node match { - case HeapMemory(address, _, used, committed, Some(max)) ⇒ + case HeapMemory(address, _, used, committed, _) ⇒ + used must be > (0L) committed must be >= (used) - used must be <= (max) - committed must be <= (max) + // Documentation java.lang.management.MemoryUsage says that committed <= max, + // but in practice that is not always true (we have seen it happen). Therefore + // we don't check the heap max value in this test. // extract is the java api StandardMetrics.extractHeapMemory(node) must not be (null) - case HeapMemory(address, _, used, committed, None) ⇒ - used must be > (0L) - committed must be > (0L) - // extract is the java api - StandardMetrics.extractCpu(node) must not be (null) } node match {