From 989a80d90fd928507bf323f2e2261f6a080325e4 Mon Sep 17 00:00:00 2001 From: Richard Imaoka Date: Mon, 21 May 2018 22:00:52 +0900 Subject: [PATCH] Better warning message on cluster sharding registration (#24906) * Better warning message on cluster sharding registration (#24295) * Extra useful message * Add [] in the log messages around membersByAge.head --- .../akka/cluster/sharding/ShardRegion.scala | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala b/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala index d50096ee69..82693fa29f 100644 --- a/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala +++ b/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala @@ -673,10 +673,19 @@ private[akka] class ShardRegion( def register(): Unit = { coordinatorSelection.foreach(_ ! registrationMessage) - if (shardBuffers.nonEmpty && retryCount >= 5) - log.warning( - "Trying to register to coordinator at [{}], but no acknowledgement. Total [{}] buffered messages.", - coordinatorSelection, shardBuffers.totalSize) + if (shardBuffers.nonEmpty && retryCount >= 5) coordinatorSelection match { + case Some(actorSelection) ⇒ + val coordinatorMessage = + if (cluster.state.unreachable(membersByAge.head)) s"Coordinator [${membersByAge.head}] is unreachable." + else s"Coordinator [${membersByAge.head}] is reachable." + log.warning( + "Trying to register to coordinator at [{}], but no acknowledgement. Total [{}] buffered messages. [{}]", + actorSelection, shardBuffers.totalSize, coordinatorMessage + ) + case None ⇒ log.warning( + "No coordinator found to register. Probably, no seed-nodes configured and manual cluster join not performed? Total [{}] buffered messages.", + shardBuffers.totalSize) + } } def registrationMessage: Any =