raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=act #21774 fix ByteString.toString to use fixed stringPrefix for all subclasses (#21775)

Browse source 
Otherwise, with 2.12,

ByteString().toString == "ByteString.ByteString1C()"

which would expose implementation details in the string representation.
This can lead to failing tests due to test expecting a particular string
representation of a ByteString which might be bad practice, yes, but is also
convenient.

The change is due to a fix in Scala for SI-9019 for which the string representation
of TraversableLike was changed which ByteString inherits.
See https://github.com/scala/scala/pull/5258/files
This commit is contained in:
Johannes Rudolph 2016-11-17 15:51:36 +01:00 • committed by Konrad Malawski
parent ef75910872
commit 97bada7deb
3 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
akka-actor/src/main/scala/akka/util/ByteString.scala
View file

@ -605,6 +605,9 @@ object ByteString {
sealed abstract class ByteString extends IndexedSeq[Byte] with IndexedSeqOptimized[Byte, ByteString] {
def apply(idx: Int): Byte
private[akka] def byteStringCompanion: ByteString.Companion
// override so that toString will also be `ByteString(...)` for the concrete subclasses
// of ByteString which changed for Scala 2.12, see https://github.com/akka/akka/issues/21774
override final def stringPrefix: String = "ByteString"
override protected[this] def newBuilder: ByteStringBuilder = ByteString.newBuilder