From f6716cda870b835a4301a416706c050c7ca836c4 Mon Sep 17 00:00:00 2001 From: Arnout Engelen Date: Mon, 23 Nov 2020 17:32:00 +0100 Subject: [PATCH] Exhaustive comparison for cache policies The 2 cases that were missing would probably never be encountered because this ordering is only used with `min` with `Ttl` objects on the right-hand side, but it still feels safer to have all the cases here. --- akka-actor/src/main/scala/akka/io/dns/internal/package.scala | 2 ++ 1 file changed, 2 insertions(+) diff --git a/akka-actor/src/main/scala/akka/io/dns/internal/package.scala b/akka-actor/src/main/scala/akka/io/dns/internal/package.scala index f78f44c9cb..4b2ec8ffbc 100644 --- a/akka-actor/src/main/scala/akka/io/dns/internal/package.scala +++ b/akka-actor/src/main/scala/akka/io/dns/internal/package.scala @@ -30,7 +30,9 @@ package object internal { case (Never, Never) => 0 case (Ttl(v1), Ttl(v2)) => v1.compare(v2) case (Never, _) => -1 + case (_, Forever) => -1 case (Forever, _) => 1 + case (_, Never) => 1 } }