raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

Handle null constructor parameters, see #3486

Browse source
This commit is contained in:
Patrik Nordwall 2013-07-03 09:47:22 +02:00
parent a6129e7d31
commit 930c53d3bc
2 changed files with 104 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

100
akka-actor-tests/src/test/java/akka/actor/JavaAPI.java
View file

@ -12,6 +12,7 @@ import akka.routing.FromConfig;
import akka.routing.NoRouter;
import akka.testkit.AkkaJUnitActorSystemResource;
import akka.testkit.AkkaSpec;
import akka.testkit.TestProbe;
import org.junit.ClassRule;
import org.junit.Test;
@ -20,8 +21,8 @@ import static org.junit.Assert.*;
public class JavaAPI {
@ClassRule
public static AkkaJUnitActorSystemResource actorSystemResource =
new AkkaJUnitActorSystemResource("JAvaAPI", AkkaSpec.testConf());
public static AkkaJUnitActorSystemResource actorSystemResource = new AkkaJUnitActorSystemResource("JavaAPI",
AkkaSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
@ -34,9 +35,9 @@ public class JavaAPI {
final LocalScope ls = LocalScope.getInstance();
final NoScopeGiven noscope = NoScopeGiven.getInstance();
final LoggerInitialized x = Logging.loggerInitialized();
final CurrentRoutees r = CurrentRoutees.getInstance();
final NoRouter nr = NoRouter.getInstance();
final FromConfig fc = FromConfig.getInstance();
@ -57,4 +58,95 @@ public class JavaAPI {
}));
assertNotNull(ref);
}
@Test
public void mustBeAbleToCreateActorWIthConstructorParams() {
ActorRef ref = system.actorOf(Props.create(ActorWithConstructorParams.class, "a", "b", new Integer(17), 18));
final TestProbe probe = new TestProbe(system);
probe.send(ref, "get");
probe.expectMsg("a-b-17-18");
}
@Test
public void mustBeAbleToCreateActorWIthBoxedAndUnBoxedConstructorParams() {
ActorRef ref = system.actorOf(Props.create(ActorWithConstructorParams.class, "a", "b", 17, new Integer(18)));
final TestProbe probe = new TestProbe(system);
probe.send(ref, "get");
probe.expectMsg("a-b-17-18");
}
@Test
public void mustBeAbleToCreateActorWIthNullConstructorParams() {
ActorRef ref = system.actorOf(Props.create(ActorWithConstructorParams.class, "a", null, null, 18));
final TestProbe probe = new TestProbe(system);
probe.send(ref, "get");
probe.expectMsg("a-null-null-18");
}
@Test
public void mustBeAbleToCreateActorWIthNullConstructorParams2() {
// without this Object array wrapper it will not compile: "reference to create is ambiguous"
ActorRef ref = system.actorOf(Props.create(ActorWithConstructorParams.class, new Object[] { null }));
final TestProbe probe = new TestProbe(system);
probe.send(ref, "get");
probe.expectMsg("null-undefined-0-0");
}
@Test
public void mustBeAbleToCreateActorWIthNullConstructorParams3() {
ActorRef ref = system.actorOf(Props.create(ActorWithConstructorParams.class, "a", null));
final TestProbe probe = new TestProbe(system);
probe.send(ref, "get");
probe.expectMsg("a-null-0-0");
}
public static class ActorWithConstructorParams extends UntypedActor {
private final String a;
private final String b;
private final Integer c;
private final int d;
public ActorWithConstructorParams(String a, String b, Integer c, int d) {
this.a = a;
this.b = b;
this.c = c;
this.d = d;
}
public ActorWithConstructorParams(String a, Object b) {
this.a = a;
this.b = String.valueOf(b);
this.c = 0;
this.d = 0;
}
public ActorWithConstructorParams(String a, int d) {
this.a = a;
this.b = "undefined";
this.c = 0;
this.d = d;
}
public ActorWithConstructorParams(Object a) {
this.a = String.valueOf(a);
this.b = "undefined";
this.c = 0;
this.d = 0;
}
public ActorWithConstructorParams(int d) {
this.a = "undefined";
this.b = "undefined";
this.c = 0;
this.d = d;
}
@Override
public void onReceive(Object msg) {
String reply = String.valueOf(a) + "-" + String.valueOf(b) + "-" + String.valueOf(c) + "-" + String.valueOf(d);
getSender().tell(reply, getSelf());
}
}
}