raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=htc #17227 always render HttpChallenge realm in double-quotes

Browse source
This commit is contained in:
Mathias 2015-04-20 16:30:42 +02:00
parent aad8704085
commit 92e992e6fc
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
akka-http-core/src/main/scala/akka/http/model/headers/HttpChallenge.scala
View file

@ -14,7 +14,7 @@ final case class HttpChallenge(scheme: String, realm: String,
params: Map[String, String] = Map.empty) extends japi.headers.HttpChallenge with ValueRenderable {
def render[R <: Rendering](r: R): r.type = {
r ~~ scheme ~~ " realm=" ~~# realm
r ~~ scheme ~~ " realm=" ~~#! realm
if (params.nonEmpty) params.foreach { case (k, v) ⇒ r ~~ ',' ~~ k ~~ '=' ~~# v }
r
}

8
akka-http-core/src/test/scala/akka/http/model/parser/HttpHeaderSpec.scala
View file

@ -337,7 +337,7 @@ class HttpHeaderSpec extends FreeSpec with Matchers {
}
"Proxy-Authenticate" in {
"Proxy-Authenticate: Basic realm=WallyWorld,attr=\"val>ue\", Fancy realm=yeah" =!=
"Proxy-Authenticate: Basic realm=\"WallyWorld\",attr=\"val>ue\", Fancy realm=\"yeah\"" =!=
`Proxy-Authenticate`(HttpChallenge("Basic", "WallyWorld", Map("attr" -> "val>ue")), HttpChallenge("Fancy", "yeah"))
}
@ -453,10 +453,10 @@ class HttpHeaderSpec extends FreeSpec with Matchers {
}
"WWW-Authenticate" in {
"WWW-Authenticate: Basic realm=WallyWorld" =!=
"WWW-Authenticate: Basic realm=\"WallyWorld\"" =!=
`WWW-Authenticate`(HttpChallenge("Basic", "WallyWorld"))
"WWW-Authenticate: BaSiC rEaLm=WallyWorld" =!=
`WWW-Authenticate`(HttpChallenge("BaSiC", "WallyWorld")).renderedTo("BaSiC realm=WallyWorld")
`WWW-Authenticate`(HttpChallenge("BaSiC", "WallyWorld")).renderedTo("BaSiC realm=\"WallyWorld\"")
"WWW-Authenticate: Basic realm=\"foo<bar\"" =!= `WWW-Authenticate`(HttpChallenge("Basic", "foo<bar"))
"""WWW-Authenticate: Digest
realm="testrealm@host.com",
@ -466,7 +466,7 @@ class HttpHeaderSpec extends FreeSpec with Matchers {
`WWW-Authenticate`(HttpChallenge("Digest", "testrealm@host.com", Map("qop" -> "auth,auth-int",
"nonce" -> "dcd98b7102dd2f0e8b11d0f600bfb0c093", "opaque" -> "5ccc069c403ebaf9f0171e9517f40e41"))).renderedTo(
"Digest realm=\"testrealm@host.com\",qop=\"auth,auth-int\",nonce=dcd98b7102dd2f0e8b11d0f600bfb0c093,opaque=5ccc069c403ebaf9f0171e9517f40e41")
"WWW-Authenticate: Basic realm=WallyWorld,attr=\"val>ue\", Fancy realm=yeah" =!=
"WWW-Authenticate: Basic realm=\"WallyWorld\",attr=\"val>ue\", Fancy realm=\"yeah\"" =!=
`WWW-Authenticate`(HttpChallenge("Basic", "WallyWorld", Map("attr" -> "val>ue")), HttpChallenge("Fancy", "yeah"))
"""WWW-Authenticate: Fancy realm="Secure Area",nonce=42""" =!=
`WWW-Authenticate`(HttpChallenge("Fancy", "Secure Area", Map("nonce" -> "42")))