Merge pull request #15771 from akka/wip-13981-balancing-pool-char-patriknw

=act #13981 Encode name of Balancing dispatcher config path

akka-actor-tests/src/test/scala/akka/routing/BalancingSpec.scala

@@ -11,6 +11,7 @@ import akka.actor.{ Props, Actor }
 import akka.testkit.{ TestLatch, ImplicitSender, AkkaSpec }
 import akka.actor.ActorRef
 import org.scalatest.BeforeAndAfterEach
+import java.net.URLEncoder
 
 object BalancingSpec {
   val counter = new AtomicInteger(1)
@@ -24,6 +25,15 @@ object BalancingSpec {
         sender() ! id
     }
   }
+
+  class Parent extends Actor {
+    val pool = context.actorOf(BalancingPool(2).props(routeeProps =
+      Props(classOf[Worker], TestLatch(0)(context.system))))
+
+    def receive = {
+      case msg ⇒ pool.forward(msg)
+    }
+  }
 }
 
 @org.junit.runner.RunWith(classOf[org.scalatest.junit.JUnitRunner])
@@ -98,5 +108,18 @@ class BalancingSpec extends AkkaSpec(
       test(pool, latch)
     }
 
+    "work with anonymous actor names" in {
+      // the dispatcher-id must not contain invalid config key characters (e.g. $a) 
+      system.actorOf(Props[Parent]) ! "hello"
+      expectMsgType[Int]
+    }
+
+    "work with encoded actor names" in {
+      val encName = URLEncoder.encode("abcå6#$€xyz", "utf-8")
+      // % is a valid config key character (e.g. %C3%A5) 
+      system.actorOf(Props[Parent], encName) ! "hello"
+      expectMsgType[Int]
+    }
+
   }
 }

akka-actor/src/main/scala/akka/routing/Balancing.scala

@@ -99,7 +99,10 @@ final case class BalancingPool(
    */
   override private[akka] def newRoutee(routeeProps: Props, context: ActorContext): Routee = {
 
-    val deployPath = context.self.path.elements.drop(1).mkString("/", "/", "")
+    val rawDeployPath = context.self.path.elements.drop(1).mkString("/", "/", "")
+    val deployPath = BalancingPool.invalidConfigKeyChars.foldLeft(rawDeployPath) { (replaced, c) ⇒
+      replaced.replace(c, '_')
+    }
     val dispatcherId = s"BalancingPool-$deployPath"
     def dispatchers = context.system.dispatchers
 
@@ -147,3 +150,6 @@ final case class BalancingPool(
 
 }
 
+object BalancingPool {
+  private val invalidConfigKeyChars = List('$', '@', ':')
+}