raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Parse service names with special characters in them #30672

Browse source
This commit is contained in:
Regis Kuckaertz 2021-09-15 16:20:43 +01:00 • committed by GitHub
parent e22152098e
commit 8187afebe9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
akka-discovery/src/main/scala/akka/discovery/config/ConfigServiceDiscovery.scala
View file

@ -7,7 +7,7 @@ package akka.discovery.config
import scala.concurrent.Future
import scala.concurrent.duration.FiniteDuration
import com.typesafe.config.Config
import com.typesafe.config.{ Config, ConfigUtil }
import akka.actor.ExtendedActorSystem
import akka.annotation.InternalApi
@ -27,7 +27,7 @@ private object ConfigServicesParser {
.entrySet()
.asScala
.map { en =>
(en.getKey, config.getConfig(en.getKey))
(en.getKey, config.getConfig(ConfigUtil.quoteString(en.getKey)))
}
.toMap

8
akka-discovery/src/test/scala/akka/discovery/config/ConfigServiceDiscoverySpec.scala
View file

@ -38,7 +38,7 @@ akka {
}
]
},
service2 = {
"service2.domain.com" = {
endpoints = []
}
}
@ -70,7 +70,11 @@ class ConfigServiceDiscoverySpec
ResolvedTarget(host = "cat", port = Some(1233), address = None),
ResolvedTarget(host = "dog", port = None, address = None))
}
"return no resolved targets if no endpoints" in {
val result = discovery.lookup("service2.domain.com", 100.millis).futureValue
result.serviceName shouldEqual "service2.domain.com"
result.addresses shouldEqual immutable.Seq.empty
}
"return no resolved targets if not in config" in {
val result = discovery.lookup("dontexist", 100.millis).futureValue
result.serviceName shouldEqual "dontexist"