=htt,str,doc #20009 Fix for found unsafe graph stages

akka-docs/rst/java/code/docs/stream/GraphStageDocTest.java

@@ -384,7 +384,8 @@ public class GraphStageDocTest extends AbstractJavaTest {
 
 
   //#async-side-channel
-  // will close upstream when the future completes
+  // will close upstream in all materializations of the stage instance
+  // when the completion stage completes
   public class KillSwitch<A> extends GraphStage<FlowShape<A, A>> {
 
     private final CompletionStage<Done> switchF;

akka-docs/rst/scala/code/docs/stream/GraphStageDocSpec.scala

@@ -274,7 +274,8 @@ class GraphStageDocSpec extends AkkaSpec {
     import system.dispatcher
 
     //#async-side-channel
-    // will close upstream when the future completes
+    // will close upstream in all materializations of the graph stage instance
+    // when the future completes
     class KillSwitch[A](switch: Future[Unit]) extends GraphStage[FlowShape[A, A]] {
 
       val in = Inlet[A]("KillSwitch.in")

akka-http-core/src/main/scala/akka/http/impl/util/StreamUtils.scala

@@ -115,10 +115,11 @@ private[http] object StreamUtils {
   def limitByteChunksStage(maxBytesPerChunk: Int): GraphStage[FlowShape[ByteString, ByteString]] =
     new SimpleLinearGraphStage[ByteString] {
       override def initialAttributes = Attributes.name("limitByteChunksStage")
-      var remaining = ByteString.empty
 
       override def createLogic(inheritedAttributes: Attributes): GraphStageLogic = new GraphStageLogic(shape) {
 
+        var remaining = ByteString.empty
+
         def splitAndPush(elem: ByteString): Unit = {
           val toPush = remaining.take(maxBytesPerChunk)
           val toKeep = remaining.drop(maxBytesPerChunk)

akka-stream/src/main/scala/akka/stream/impl/Timers.scala

@@ -76,9 +76,9 @@ private[stream] object Timers {
   }
 
   final class Idle[T](timeout: FiniteDuration) extends SimpleLinearGraphStage[T] {
-    private var nextDeadline: Deadline = Deadline.now + timeout
 
     override def createLogic(inheritedAttributes: Attributes): GraphStageLogic = new TimerGraphStageLogic(shape) {
+      private var nextDeadline: Deadline = Deadline.now + timeout
       setHandler(in, new InHandler {
         override def onPush(): Unit = {
           nextDeadline = Deadline.now + timeout