Merge pull request #30281 from Captain1653/unchecked-cast

Remove unchecked cast from SourceTest and FlowTest
This commit is contained in:
Patrik Nordwall 2021-07-06 11:06:21 +02:00 committed by GitHub
commit 7f3bfb1a30
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 32 deletions

View file

@ -32,6 +32,7 @@ import java.util.concurrent.CompletionStage;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import java.time.Duration;
@ -290,7 +291,6 @@ public class FlowTest extends StreamTest {
probe.expectMsgEquals(6);
}
@SuppressWarnings("unchecked")
@Test
public void mustBeAbleToUseGroupBy() throws Exception {
final Iterable<String> input = Arrays.asList("Aaa", "Abb", "Bcc", "Cdd", "Cee");
@ -308,22 +308,14 @@ public class FlowTest extends StreamTest {
final CompletionStage<List<List<String>>> future =
Source.from(input).via(flow).limit(10).runWith(Sink.seq(), system);
final Object[] result = future.toCompletableFuture().get(1, TimeUnit.SECONDS).toArray();
Arrays.sort(
result,
(Comparator<Object>)
(Object)
new Comparator<List<String>>() {
@Override
public int compare(List<String> o1, List<String> o2) {
return o1.get(0).charAt(0) - o2.get(0).charAt(0);
}
});
final List<List<String>> result =
future.toCompletableFuture().get(1, TimeUnit.SECONDS).stream()
.sorted(Comparator.comparingInt(list -> list.get(0).charAt(0)))
.collect(Collectors.toList());
assertArrayEquals(
new Object[] {
Arrays.asList("Aaa", "Abb"), Arrays.asList("Bcc"), Arrays.asList("Cdd", "Cee")
},
assertEquals(
Arrays.asList(
Arrays.asList("Aaa", "Abb"), Arrays.asList("Bcc"), Arrays.asList("Cdd", "Cee")),
result);
}

View file

@ -36,6 +36,7 @@ import java.util.concurrent.CompletionStage;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import java.util.stream.Stream;
@ -177,7 +178,6 @@ public class SourceTest extends StreamTest {
probe.expectMsgEquals(6);
}
@SuppressWarnings("unchecked")
@Test
public void mustBeAbleToUseGroupBy() throws Exception {
final Iterable<String> input = Arrays.asList("Aaa", "Abb", "Bcc", "Cdd", "Cee");
@ -195,22 +195,14 @@ public class SourceTest extends StreamTest {
final CompletionStage<List<List<String>>> future =
source.grouped(10).runWith(Sink.head(), system);
final Object[] result = future.toCompletableFuture().get(1, TimeUnit.SECONDS).toArray();
Arrays.sort(
result,
(Comparator<Object>)
(Object)
new Comparator<List<String>>() {
@Override
public int compare(List<String> o1, List<String> o2) {
return o1.get(0).charAt(0) - o2.get(0).charAt(0);
}
});
final List<List<String>> result =
future.toCompletableFuture().get(1, TimeUnit.SECONDS).stream()
.sorted(Comparator.comparingInt(list -> list.get(0).charAt(0)))
.collect(Collectors.toList());
assertArrayEquals(
new Object[] {
Arrays.asList("Aaa", "Abb"), Arrays.asList("Bcc"), Arrays.asList("Cdd", "Cee")
},
assertEquals(
Arrays.asList(
Arrays.asList("Aaa", "Abb"), Arrays.asList("Bcc"), Arrays.asList("Cdd", "Cee")),
result);
}