From aa1b39c97d9bdca805bb78aaa750dcf440ffeff8 Mon Sep 17 00:00:00 2001 From: Roland Date: Fri, 11 Nov 2011 11:37:34 +0100 Subject: [PATCH 1/3] use actor.self when logging system message processing errors --- akka-actor/src/main/scala/akka/dispatch/Mailbox.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/akka-actor/src/main/scala/akka/dispatch/Mailbox.scala b/akka-actor/src/main/scala/akka/dispatch/Mailbox.scala index 026ad67875..ae54c5bf50 100644 --- a/akka-actor/src/main/scala/akka/dispatch/Mailbox.scala +++ b/akka-actor/src/main/scala/akka/dispatch/Mailbox.scala @@ -205,7 +205,7 @@ abstract class Mailbox(val actor: ActorCell) extends AbstractMailbox with Messag } } catch { case e ⇒ - actor.app.eventStream.publish(Error(e, this, "exception during processing system messages, dropping " + SystemMessage.size(nextMessage) + " messages!")) + actor.app.eventStream.publish(Error(e, actor.self, "exception during processing system messages, dropping " + SystemMessage.size(nextMessage) + " messages!")) throw e } } From 817130d65c39739e1b0e8e0eb0beb0cff0877e93 Mon Sep 17 00:00:00 2001 From: Roland Date: Fri, 11 Nov 2011 12:01:14 +0100 Subject: [PATCH 2/3] add specific override from System.getProperties for akka.test.timefactor - I suspect that this caused some of the recent timeouts, because that got implicitly disabled by my moving TestTimeFactor into AkkaConfig - special-cased since the full solution of making everything overridable is being worked out by Havoc --- akka-actor/src/main/scala/akka/actor/ActorSystem.scala | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/akka-actor/src/main/scala/akka/actor/ActorSystem.scala b/akka-actor/src/main/scala/akka/actor/ActorSystem.scala index 734973cc13..86c47522b0 100644 --- a/akka-actor/src/main/scala/akka/actor/ActorSystem.scala +++ b/akka-actor/src/main/scala/akka/actor/ActorSystem.scala @@ -91,7 +91,10 @@ class ActorSystem(val name: String, val config: Configuration) extends ActorRefF val ActorTimeoutMillis = ActorTimeout.duration.toMillis val SerializeAllMessages = getBool("akka.actor.serialize-messages", false) - val TestTimeFactor = getDouble("akka.test.timefactor", 1.0) + val TestTimeFactor = + try java.lang.Double.parseDouble(System.getProperty("akka.test.timefactor")) catch { + case _: Exception ⇒ getDouble("akka.test.timefactor", 1.0) + } val TestEventFilterLeeway = Duration(getDouble("akka.test.filter-leeway", 0.5), DefaultTimeUnit) val LogLevel = getString("akka.loglevel", "INFO") From ad79b552ccd313ce97b0b0d1b3a5cea7459b0de9 Mon Sep 17 00:00:00 2001 From: Roland Date: Fri, 11 Nov 2011 12:32:48 +0100 Subject: [PATCH 3/3] make FSMTimingSpec even more robust (no, really!) - plus remove one unused local import to make it 200% negative --- akka-actor-tests/src/test/scala/akka/actor/FSMTimingSpec.scala | 3 +-- .../src/test/scala/akka/routing/ActorPoolSpec.scala | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/akka-actor-tests/src/test/scala/akka/actor/FSMTimingSpec.scala b/akka-actor-tests/src/test/scala/akka/actor/FSMTimingSpec.scala index bfda48fba9..e2dc9f098e 100644 --- a/akka-actor-tests/src/test/scala/akka/actor/FSMTimingSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/actor/FSMTimingSpec.scala @@ -181,12 +181,11 @@ object FSMTimingSpec { } when(TestCancelTimer) { case Ev(Tick) ⇒ - tester ! Tick setTimer("hallo", Tock, 1 milli, false) TestKit.awaitCond(context.hasMessages, 1 second) cancelTimer("hallo") setTimer("hallo", Tock, 500 millis, false) - stay + stay replying Tick case Ev(Tock) ⇒ tester ! Tock stay diff --git a/akka-actor-tests/src/test/scala/akka/routing/ActorPoolSpec.scala b/akka-actor-tests/src/test/scala/akka/routing/ActorPoolSpec.scala index 5e34a3c2ed..305d70e00a 100644 --- a/akka-actor-tests/src/test/scala/akka/routing/ActorPoolSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/routing/ActorPoolSpec.scala @@ -329,8 +329,6 @@ class ActorPoolSpec extends AkkaSpec { } "support typed actors" in { - import RoutingSpec._ - val pool = app.createProxy[Foo](new Actor with DefaultActorPool with BoundedCapacityStrategy with MailboxPressureCapacitor with SmallestMailboxSelector with Filter with RunningMeanBackoff with BasicRampup { def lowerBound = 1 def upperBound = 5