raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

[not for merge] Warnings as errors in akka-actor (#26634)

Browse source 
Warnings as errors in akka-actor
This commit is contained in:
Arnout Engelen 2019-04-03 13:13:44 +02:00 • committed by GitHub
parent 18802420fb
commit 76479b8770
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
68 changed files with 313 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

7
akka-actor/src/main/scala/akka/io/TcpConnection.scala
View file

@ -17,6 +17,7 @@ import akka.io.Inet.SocketOption
import akka.io.SelectionHandler._
import akka.io.Tcp._
import akka.util.ByteString
import com.github.ghik.silencer.silent
import scala.annotation.tailrec
import scala.collection.immutable
@ -202,6 +203,7 @@ private[io] abstract class TcpConnection(val tcp: TcpExt, val channel: SocketCha
// AUXILIARIES and IMPLEMENTATION
/** used in subclasses to start the common machinery above once a channel is connected */
@silent
def completeConnect(
registration: ChannelRegistration,
commander: ActorRef,
@ -415,8 +417,9 @@ private[io] abstract class TcpConnection(val tcp: TcpExt, val channel: SocketCha
case Write(data, ack) if data.nonEmpty => PendingBufferWrite(commander, data, ack, tail)
case WriteFile(path, offset, count, ack) =>
PendingWriteFile(commander, Paths.get(path), offset, count, ack, tail)
case WritePath(path, offset, count, ack) => PendingWriteFile(commander, path, offset, count, ack, tail)
case CompoundWrite(h, t) => create(h, t)
case WritePath(path, offset, count, ack) =>
PendingWriteFile(commander, path, offset, count, ack, tail)
case CompoundWrite(h, t) => create(h, t)
case x @ Write(_, ack) => // empty write with either an ACK or a non-standard NoACK
if (x.wantsAck) commander ! ack
create(tail)