improvements from the first round of feedback, see #2885 and #2887

This commit is contained in:
Mathias 2013-01-17 17:29:44 +01:00
parent 9bcca4003a
commit 7384e07d9b
12 changed files with 248 additions and 211 deletions

View file

@ -20,7 +20,7 @@ import akka.util.ByteString
import Tcp._
class TcpConnectionSpec extends AkkaSpec("akka.io.tcp.register-timeout = 500ms") {
val serverAddress = TemporaryServerAddress.get("127.0.0.1")
val serverAddress = TemporaryServerAddress("127.0.0.1")
"An outgoing connection" must {
// common behavior
@ -245,7 +245,7 @@ class TcpConnectionSpec extends AkkaSpec("akka.io.tcp.register-timeout = 500ms")
assertActorTerminated(connectionActor)
}
val UnboundAddress = TemporaryServerAddress.get("127.0.0.1")
val UnboundAddress = TemporaryServerAddress("127.0.0.1")
"report failed connection attempt when target is unreachable" in
withUnacceptedConnection(connectionActorCons = createConnectionActor(serverAddress = UnboundAddress)) { setup
import setup._
@ -397,7 +397,7 @@ class TcpConnectionSpec extends AkkaSpec("akka.io.tcp.register-timeout = 500ms")
commander: ActorRef): TestActorRef[TcpOutgoingConnection] = {
TestActorRef(
new TcpOutgoingConnection(selector, commander, serverAddress, localAddress, options) {
new TcpOutgoingConnection(selector, Tcp(system), commander, serverAddress, localAddress, options) {
override def postRestart(reason: Throwable) {
// ensure we never restart
context.stop(self)