raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Merge pull request #25847 from chbatey/dns-warn

Browse source 
Warn about async-dns lack of support for search domains
This commit is contained in:
Patrik Nordwall 2018-11-07 12:36:00 +01:00 • committed by GitHub
commit 70176341d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
akka-actor/src/main/scala/akka/io/dns/DnsSettings.scala
View file

@ -68,7 +68,7 @@ object DnsSettings {
/** /**
* INTERNAL API * INTERNAL API
* Find out the default search domains that Java would use normally, e.g. when using InetAddress to resolve domains. * Find out the default search lists that Java would use normally, e.g. when using InetAddress to resolve domains.
* *
* The default nameservers are attempted to be obtained from: jndi-dns and from `sun.net.dnsResolverConfiguration` * The default nameservers are attempted to be obtained from: jndi-dns and from `sun.net.dnsResolverConfiguration`
* as a fallback (which is expected to fail though when running on JDK9+ due to the module encapsulation of sun packages). * as a fallback (which is expected to fail though when running on JDK9+ due to the module encapsulation of sun packages).

4
akka-docs/src/main/paradox/io-dns.md
View file

@ -2,7 +2,9 @@
@@@ warning @@@ warning
`async-dns` does not currently support TCP fallback and so DNS repsonses may be truncated. See [#25460](https://github.com/akka/akka/issues/25460) `async-dns` does not support:
* [Local hosts file](https://github.com/akka/akka/issues/25846) e.g. `/etc/hosts` on Unix systems
* [Search domains](https://github.com/akka/akka/issues/25825) e.g. in `/etc/resolve.conf` on Unix systems
@@@ @@@