Convert 2.5.x MiMa excludes to subdirectory style
Using this script: ```sh set -ex FILE=$1 DIR=`dirname $FILE` TMP_FILE=$DIR/_existing.excludes FINAL_FILE=$DIR/2.5.x.backwards.excludes/_existing.excludes mv $FILE $TMP_FILE mkdir $DIR/2.5.x.backwards.excludes (echo "# This file contains all excludes added before changing to the subdirectory style" && cat $TMP_FILE) > $FINAL_FILE rm $TMP_FILE git add $FINAL_FILE ```
This commit is contained in:
parent
ba67d6205c
commit
650068aa45
14 changed files with 18 additions and 1 deletions
|
|
@ -227,7 +227,11 @@ an error like this:
|
||||||
[error] filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.scaladsl.FlowOps.foldAsync")
|
[error] filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.scaladsl.FlowOps.foldAsync")
|
||||||
```
|
```
|
||||||
|
|
||||||
In such situations it's good to consult with a core team member if the violation can be safely ignored (by adding the above snippet to `<module>/src/main/mima-filters/<last-version>.backwards.excludes`), or if it would indeed break binary compatibility.
|
In such situations it's good to consult with a core team member whether the violation can be safely ignored or if it would indeed
|
||||||
|
break binary compatibility. If the violation can be ignored add exclude statements from the mima output to
|
||||||
|
a new file named `<module>/src/main/mima-filters/<last-version>.backwards.excludes/<pr-or-issue>-<issue-number>-<description>.excludes`,
|
||||||
|
e.g. `akka-actor/src/main/mima-filters/2.5.x.backwards.excludes/pr-12345-rename-internal-classes.excludes`. Make sure to add a comment
|
||||||
|
in the file that describes briefly why the incompatibility can be ignored.
|
||||||
|
|
||||||
Situations when it may be fine to ignore a MiMa issued warning include:
|
Situations when it may be fine to ignore a MiMa issued warning include:
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# excludes for 2.6
|
# excludes for 2.6
|
||||||
|
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.actor.Inbox$")
|
ProblemFilters.exclude[MissingClassProblem]("akka.actor.Inbox$")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Upgrade to protobuf 3
|
# Upgrade to protobuf 3
|
||||||
ProblemFilters.exclude[Problem]("akka.cluster.metrics.protobuf.msg.ClusterMetricsMessages*")
|
ProblemFilters.exclude[Problem]("akka.cluster.metrics.protobuf.msg.ClusterMetricsMessages*")
|
||||||
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.cluster.metrics.protobuf.MessageSerializer.compress")
|
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.cluster.metrics.protobuf.MessageSerializer.compress")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# #26877 Performance improvements of DDataShard
|
# #26877 Performance improvements of DDataShard
|
||||||
ProblemFilters.exclude[Problem]("akka.cluster.sharding.Shard.*")
|
ProblemFilters.exclude[Problem]("akka.cluster.sharding.Shard.*")
|
||||||
|
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Protobuf 3
|
# Protobuf 3
|
||||||
ProblemFilters.exclude[Problem]("akka.cluster.client.protobuf.msg.*")
|
ProblemFilters.exclude[Problem]("akka.cluster.client.protobuf.msg.*")
|
||||||
ProblemFilters.exclude[Problem]("akka.cluster.pubsub.protobuf.msg.*")
|
ProblemFilters.exclude[Problem]("akka.cluster.pubsub.protobuf.msg.*")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# 26757 add timings to cluster heart beat messages
|
# 26757 add timings to cluster heart beat messages
|
||||||
ProblemFilters.exclude[MissingTypesProblem]("akka.cluster.ClusterHeartbeatSender$Heartbeat$")
|
ProblemFilters.exclude[MissingTypesProblem]("akka.cluster.ClusterHeartbeatSender$Heartbeat$")
|
||||||
ProblemFilters.exclude[MissingTypesProblem]("akka.cluster.ClusterHeartbeatSender$HeartbeatRsp$")
|
ProblemFilters.exclude[MissingTypesProblem]("akka.cluster.ClusterHeartbeatSender$HeartbeatRsp$")
|
||||||
|
|
@ -1,2 +1,3 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Made final when removing api may change
|
# Made final when removing api may change
|
||||||
ProblemFilters.exclude[FinalClassProblem]("akka.coordination.lease.LeaseUsageSettings")
|
ProblemFilters.exclude[FinalClassProblem]("akka.coordination.lease.LeaseUsageSettings")
|
||||||
|
|
@ -1,2 +1,3 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Upgrade to protobuf 3
|
# Upgrade to protobuf 3
|
||||||
ProblemFilters.exclude[Problem]("akka.cluster.ddata.protobuf.*")
|
ProblemFilters.exclude[Problem]("akka.cluster.ddata.protobuf.*")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Protobuf 3
|
# Protobuf 3
|
||||||
ProblemFilters.exclude[Problem]("akka.remote.testconductor.TestConductorProtocol*")
|
ProblemFilters.exclude[Problem]("akka.remote.testconductor.TestConductorProtocol*")
|
||||||
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.remote.testconductor.ProtobufDecoder.this")
|
ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.remote.testconductor.ProtobufDecoder.this")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Remove ActorPublisher/Subscriber
|
# Remove ActorPublisher/Subscriber
|
||||||
|
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.persistence.query.journal.leveldb.LiveEventsByTagPublisher")
|
ProblemFilters.exclude[MissingClassProblem]("akka.persistence.query.journal.leveldb.LiveEventsByTagPublisher")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# excludes for 2.6
|
# excludes for 2.6
|
||||||
|
|
||||||
# Remove deprecated features since 2.5.0 https://github.com/akka/akka/issues/26492
|
# Remove deprecated features since 2.5.0 https://github.com/akka/akka/issues/26492
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# #26190 remove actorFor
|
# #26190 remove actorFor
|
||||||
ProblemFilters.exclude[DirectMissingMethodProblem]("akka.remote.RemoteActorRefProvider.actorFor")
|
ProblemFilters.exclude[DirectMissingMethodProblem]("akka.remote.RemoteActorRefProvider.actorFor")
|
||||||
|
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Java9 RS APIs and more that was missed in a few earlier versions
|
# Java9 RS APIs and more that was missed in a few earlier versions
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.stream.javadsl.JavaFlowSupport$Source")
|
ProblemFilters.exclude[MissingClassProblem]("akka.stream.javadsl.JavaFlowSupport$Source")
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.stream.javadsl.JavaFlowSupport")
|
ProblemFilters.exclude[MissingClassProblem]("akka.stream.javadsl.JavaFlowSupport")
|
||||||
|
|
@ -1,3 +1,4 @@
|
||||||
|
# This file contains all excludes added before changing to the subdirectory style
|
||||||
# Remove JavaTestKit https://github.com/akka/akka/issues/26189
|
# Remove JavaTestKit https://github.com/akka/akka/issues/26189
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.testkit.JavaTestKit")
|
ProblemFilters.exclude[MissingClassProblem]("akka.testkit.JavaTestKit")
|
||||||
ProblemFilters.exclude[MissingClassProblem]("akka.testkit.JavaTestKit$*")
|
ProblemFilters.exclude[MissingClassProblem]("akka.testkit.JavaTestKit$*")
|
||||||
Loading…
Add table
Add a link
Reference in a new issue