Add CI check for wrong mima filter directories (#31088)

And fix incorrect filter mima directory for 31055
This commit is contained in:
Johan Andrén 2022-02-02 11:08:48 +01:00 committed by GitHub
parent c14855fd8b
commit 5dc6755ad2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 1 deletions

View file

@ -38,3 +38,6 @@ jobs:
- name: Report MiMa Binary Issues
run: sbt -jvm-opts .jvmopts-ci "+~ ${{ matrix.scalaVersion }} mimaReportBinaryIssues"
- name: Check correct MiMa filter directories
run: sbt -jvm-opts .jvmopts-ci checkMimaFilterDirectories

View file

@ -18,9 +18,21 @@ object MiMa extends AutoPlugin {
override def requires = MimaPlugin
override def trigger = allRequirements
val checkMimaFilterDirectories =
taskKey[Unit]("Check that the mima directories are correct compared to latest version")
override val projectSettings = Seq(
mimaReportSignatureProblems := true,
mimaPreviousArtifacts := akkaPreviousArtifacts(name.value, organization.value, scalaBinaryVersion.value))
mimaPreviousArtifacts := akkaPreviousArtifacts(name.value, organization.value, scalaBinaryVersion.value),
checkMimaFilterDirectories := checkFilterDirectories(baseDirectory.value))
def checkFilterDirectories(moduleRoot: File): Unit = {
val nextVersionFilterDir = moduleRoot / "src" / "main" / "mima-filters" / s"2.6.${latestPatchOf26 + 1}.backwards.excludes"
if (nextVersionFilterDir.exists()) {
throw new IllegalArgumentException(s"Incorrect mima filter directory exists: '${nextVersionFilterDir}' " +
s"should be with number from current release '${moduleRoot / "src" / "main" / "mima-filters" / s"2.6.${latestPatchOf26}.backwards.excludes"}")
}
}
def akkaPreviousArtifacts(
projectName: String,