raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Removing pointless AtomicReference since register/unregister is already lock protected

Browse source
This commit is contained in:
Viktor Klang 2011-10-13 14:18:16 +02:00
parent 963ea0d9b2
commit 54b70b1017
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
akka-actor/src/main/scala/akka/dispatch/PinnedDispatcher.scala
View file

@ -30,19 +30,20 @@ class PinnedDispatcher(_actor: ActorCell, _name: String, _mailboxType: MailboxTy
def this() = this(Dispatchers.MAILBOX_TYPE)
protected[akka] val owner = new AtomicReference[ActorCell](_actor)
@volatile
protected[akka] var owner: ActorCell = _actor
//Relies on an external lock provided by MessageDispatcher.attach
protected[akka] override def register(actorCell: ActorCell) = {
val actor = owner.get()
val actor = owner
if ((actor ne null) && actorCell != actor) throw new IllegalArgumentException("Cannot register to anyone but " + actor)
owner.compareAndSet(null, actorCell) //Register if unregistered
owner = actorCell
super.register(actorCell)
}
//Relies on an external lock provided by MessageDispatcher.detach
protected[akka] override def unregister(actor: ActorCell) = {
super.unregister(actor)
owner.compareAndSet(actor, null) //Unregister (prevent memory leak)
owner = null
}
}