Issue references to FIXMEs in Typed (#26513)

* Issue references to FIXMEs in Typed

* comment out ctx.ask example with 2 param

* doesn't compile with 2.13, separarate issue created

akka-actor-typed-tests/src/test/scala/akka/actor/typed/ActorContextSpec.scala

@@ -67,7 +67,7 @@ abstract class ActorContextSpec extends ScalaTestWithActorTestKit("""
     akka.loggers = [akka.testkit.TestEventListener]
   """) with WordSpecLike {
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import scaladsl.adapter._
   implicit val untypedSystem = system.toUntyped
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/AskSpec.scala

@@ -31,10 +31,10 @@ class AskSpec extends ScalaTestWithActorTestKit("""
   akka.loggers = [ akka.testkit.TestEventListener ]
   """) with WordSpecLike {
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import AskSpec._
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import scaladsl.adapter._
   implicit val untypedSystem = system.toUntyped
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/DeferredSpec.scala

@@ -37,7 +37,7 @@ class DeferredSpec extends ScalaTestWithActorTestKit("""
   import DeferredSpec._
   implicit val testSettings = TestKitSettings(system)
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import scaladsl.adapter._
   implicit val untypedSystem = system.toUntyped
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/InterceptSpec.scala

@@ -26,7 +26,7 @@ class InterceptSpec extends ScalaTestWithActorTestKit("""
   import BehaviorInterceptor._
   import InterceptSpec._
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import scaladsl.adapter._
   implicit val untypedSystem = system.toUntyped
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/SupervisionSpec.scala

@@ -254,7 +254,7 @@ class SupervisionSpec extends ScalaTestWithActorTestKit("""
   private val nameCounter = Iterator.from(0)
   private def nextName(prefix: String = "a"): String = s"$prefix-${nameCounter.next()}"
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import akka.actor.typed.scaladsl.adapter._
 
   implicit val untypedSystem = system.toUntyped

akka-actor-typed-tests/src/test/scala/akka/actor/typed/TimerSpec.scala

@@ -22,7 +22,7 @@ class TimerSpec extends ScalaTestWithActorTestKit("""
     akka.loggers = [ akka.testkit.TestEventListener ]
   """) with WordSpecLike {
 
-  // FIXME eventfilter support in typed testkit
+  // FIXME #24348: eventfilter support in typed testkit
   import scaladsl.adapter._
   implicit val untypedSystem = system.toUntyped
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/scaladsl/ActorContextAskSpec.scala

@@ -33,7 +33,7 @@ object ActorContextAskSpec {
 
 class ActorContextAskSpec extends ScalaTestWithActorTestKit(ActorContextAskSpec.config) with WordSpecLike {
 
-  implicit val untyped = system.toUntyped // FIXME no typed event filter yet
+  implicit val untyped = system.toUntyped // FIXME #24348: eventfilter support in typed testkit
 
   "The Scala DSL ActorContext" must {
 

akka-actor-typed-tests/src/test/scala/akka/actor/typed/scaladsl/MessageAdapterSpec.scala

@@ -33,7 +33,7 @@ object MessageAdapterSpec {
 
 class MessageAdapterSpec extends ScalaTestWithActorTestKit(MessageAdapterSpec.config) with WordSpecLike {
 
-  implicit val untyped = system.toUntyped // FIXME no typed event filter yet
+  implicit val untyped = system.toUntyped // FIXME #24348: eventfilter support in typed testkit
 
   "Message adapters" must {
 

akka-actor-typed/src/main/scala/akka/actor/typed/internal/WrappingBehavior.scala

@@ -8,7 +8,7 @@ import akka.actor.typed.Behavior
 import akka.annotation.DoNotInherit
 import akka.annotation.InternalApi
 
-// FIXME see if we can completely eliminate this with the help of BehaviorInterceptor instead
+// FIXME #26504: see if we can completely eliminate this with the help of BehaviorInterceptor instead
 
 /**
  * INTERNAL API

akka-actor-typed/src/main/scala/akka/actor/typed/internal/receptionist/LocalReceptionist.scala

@@ -56,7 +56,7 @@ private[akka] object LocalReceptionist extends ReceptionistBehaviorProvider {
 
     /*
      * Hack to allow multiple termination notifications per target
-     * FIXME: replace by simple map in our state
+     * FIXME #26505: replace by simple map in our state
      */
     def watchWith(ctx: ActorContext[Any], target: ActorRef[_], msg: InternalCommand): Unit =
       ctx.spawnAnonymous[Nothing](Behaviors.setup[Nothing] { innerCtx =>

akka-actor-typed/src/main/scala/akka/actor/typed/scaladsl/Routers.scala

@@ -23,7 +23,6 @@ object Routers {
    * until the deregistration is complete to minimize the risk of lost messages.
    */
   def group[T](key: ServiceKey[T]): GroupRouter[T] =
-    // fixme: potential detection of cluster and selecting a different impl https://github.com/akka/akka/issues/26355
     new GroupRouterBuilder[T](key)
 
   /**

akka-cluster-sharding-typed/src/test/scala/akka/cluster/sharding/typed/scaladsl/ClusterShardingPersistenceSpec.scala

@@ -160,7 +160,7 @@ class ClusterShardingPersistenceSpec
     p.expectTerminated(ref, p.remainingOrDefault)
 
     // also make sure that the entity is removed from the Shard before continuing
-    // FIXME rewrite this with Typed API when region queries are supported
+    // FIXME #24466: rewrite this with Typed API when region queries are supported
     import akka.actor.typed.scaladsl.adapter._
     val regionStateProbe = TestProbe[CurrentShardRegionState]()
     val untypedRegion = UntypedClusterSharding(system.toUntyped)

akka-cluster-sharding-typed/src/test/scala/akka/cluster/sharding/typed/scaladsl/ClusterShardingSpec.scala

@@ -338,10 +338,6 @@ class ClusterShardingSpec extends ScalaTestWithActorTestKit(ClusterShardingSpec.
       val p = TestProbe[TheReply]()
 
       spawn(Behaviors.setup[TheReply] { ctx =>
-        // FIXME is the implicit ClassTag difficult to use?
-        // it works fine when there is a single parameter apply,
-        // but trouble when more parameters and this doesn't compile
-        //ctx.ask(aliceRef)(x => WhoAreYou(x)) {
         ctx.ask(aliceRef)(WhoAreYou) {
           case Success(name) => TheReply(name)
           case Failure(ex)   => TheReply(ex.getMessage)
@@ -356,6 +352,19 @@ class ClusterShardingSpec extends ScalaTestWithActorTestKit(ClusterShardingSpec.
       p.receiveMessage().s should startWith("I'm alice")
 
       aliceRef ! StopPlz()
+
+      // FIXME #26514: doesn't compile with Scala 2.13.0-M5
+      /*
+      // make sure request with multiple parameters compile
+      Behaviors.setup[TheReply] { ctx =>
+        ctx.ask(aliceRef)(WhoAreYou2(17, _)) {
+          case Success(name) => TheReply(name)
+          case Failure(ex)   => TheReply(ex.getMessage)
+        }
+
+        Behaviors.empty
+      }
+     */
     }
 
     "EntityRef - AskTimeoutException" in {

akka-cluster-typed/src/main/scala/akka/cluster/ddata/typed/internal/ReplicatorBehavior.scala

@@ -40,7 +40,7 @@ import akka.actor.typed.Terminated
       val untypedReplicator = underlyingReplicator match {
         case Some(ref) => ref
         case None      =>
-          // FIXME perhaps add supervisor for restarting
+          // FIXME perhaps add supervisor for restarting, see PR https://github.com/akka/akka/pull/25988
           val untypedReplicatorProps = dd.Replicator.props(settings)
           ctx.actorOf(untypedReplicatorProps, name = "underlying")
       }

akka-cluster-typed/src/main/scala/akka/cluster/typed/internal/receptionist/ClusterReceptionist.scala

@@ -122,7 +122,7 @@ private[typed] object ClusterReceptionist extends ReceptionistBehaviorProvider {
 
       /*
        * Hack to allow multiple termination notifications per target
-       * FIXME: replace by simple map in our state
+       * FIXME #26505: replace by simple map in our state
        */
       def watchWith(ctx: ActorContext[Command], target: ActorRef[_], msg: InternalCommand): Unit =
         ctx.spawnAnonymous[Nothing](Behaviors.setup[Nothing] { innerCtx =>

akka-cluster-typed/src/test/java/jdocs/akka/cluster/typed/BasicClusterExampleTest.java

@@ -14,8 +14,7 @@ import akka.actor.testkit.typed.javadsl.TestProbe;
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
 
-// FIXME these tests are awaiting typed Java testkit to be able to await cluster forming like in
+// FIXME use awaitAssert to await cluster forming like in BasicClusterExampleSpec
-// BasicClusterExampleSpec
 public class BasicClusterExampleTest { // extends JUnitSuite {
 
   private Config clusterConfig =

akka-persistence-typed/src/test/scala/akka/persistence/typed/scaladsl/EventSourcedBehaviorStashSpec.scala

@@ -488,7 +488,7 @@ class EventSourcedBehaviorStashSpec
     "discard when stash has reached limit with default dropped setting" in {
       val probe = TestProbe[AnyRef]()
       system.toUntyped.eventStream.subscribe(probe.ref.toUntyped, classOf[Dropped])
-      val behavior = EventSourcedBehavior[String, String, Boolean](PersistenceId("stash-is-full-drop"),
+      val behavior = EventSourcedBehavior[String, String, Boolean](persistenceId = PersistenceId("stash-is-full-drop"),
                                                                    emptyState = false,
                                                                    commandHandler = { (state, command) =>
                                                                      state match {
@@ -510,8 +510,7 @@ class EventSourcedBehaviorStashSpec
                                                                              Effect
                                                                                .persist("unstash")
                                                                                .thenUnstashAll()
-                                                                               // FIXME this is run before unstash, so not sequentially as the docs say
+                                                                               // FIXME #26489: this is run before unstash, so not sequentially as the docs say
-                                                                               // https://github.com/akka/akka/issues/26489
                                                                                .thenRun(_ =>
                                                                                  probe.ref ! "done-unstashing")
                                                                            case _ =>
@@ -587,6 +586,6 @@ class EventSourcedBehaviorStashSpec
     }
   }
 
-  // FIXME test combination with PoisonPill
+  // FIXME #24687: test combination with PoisonPill
 
 }