Add DeleteEventsCompleted in signal handler for logging consistency #26606

This commit is contained in:
Helena Edelson 2019-03-25 12:19:53 -07:00 committed by GitHub
parent 6a46185f87
commit 43bd0dc4e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -22,8 +22,8 @@ import akka.annotation.InternalApi
import akka.persistence.JournalProtocol import akka.persistence.JournalProtocol
import akka.persistence.Recovery import akka.persistence.Recovery
import akka.persistence.RecoveryPermitter import akka.persistence.RecoveryPermitter
import akka.persistence.SnapshotMetadata
import akka.persistence.SnapshotProtocol import akka.persistence.SnapshotProtocol
import akka.persistence.typed.DeleteEventsCompleted
import akka.persistence.typed.DeleteEventsFailed import akka.persistence.typed.DeleteEventsFailed
import akka.persistence.typed.DeleteSnapshotsCompleted import akka.persistence.typed.DeleteSnapshotsCompleted
import akka.persistence.typed.DeleteSnapshotsFailed import akka.persistence.typed.DeleteSnapshotsFailed
@ -90,19 +90,21 @@ private[akka] final case class EventSourcedBehaviorImpl[Command, Event, State](
val actualSignalHandler: PartialFunction[Signal, Unit] = signalHandler.orElse { val actualSignalHandler: PartialFunction[Signal, Unit] = signalHandler.orElse {
// default signal handler is always the fallback // default signal handler is always the fallback
case SnapshotCompleted(meta) case SnapshotCompleted(meta)
ctx.log.debug("Save snapshot successful, snapshot metadata [{}]", meta) ctx.log.debug("Save snapshot successful, snapshot metadata [{}].", meta)
case SnapshotFailed(meta, failure) case SnapshotFailed(meta, failure)
ctx.log.error(failure, "Save snapshot failed, snapshot metadata [{}]", meta) ctx.log.error(failure, "Save snapshot failed, snapshot metadata [{}].", meta)
case DeleteSnapshotsCompleted(DeletionTarget.Individual(meta)) => case DeleteSnapshotsCompleted(DeletionTarget.Individual(meta)) =>
ctx.log.debug(s"Persistent snapshot [{}] deleted successfully.", meta) ctx.log.debug("Persistent snapshot [{}] deleted successfully.", meta)
case DeleteSnapshotsCompleted(DeletionTarget.Criteria(criteria)) => case DeleteSnapshotsCompleted(DeletionTarget.Criteria(criteria)) =>
ctx.log.debug(s"Persistent snapshots given criteria [{}] deleted successfully.", criteria) ctx.log.debug("Persistent snapshots given criteria [{}] deleted successfully.", criteria)
case DeleteSnapshotsFailed(DeletionTarget.Individual(meta), failure) => case DeleteSnapshotsFailed(DeletionTarget.Individual(meta), failure) =>
ctx.log.warning("Failed to delete snapshot with meta [{}] due to [{}].", meta, failure) ctx.log.warning("Failed to delete snapshot with meta [{}] due to [{}].", meta, failure)
case DeleteSnapshotsFailed(DeletionTarget.Criteria(criteria), failure) => case DeleteSnapshotsFailed(DeletionTarget.Criteria(criteria), failure) =>
ctx.log.warning("Failed to delete snapshots given criteria [{}] due to [{}].", criteria, failure) ctx.log.warning("Failed to delete snapshots given criteria [{}] due to [{}].", criteria, failure)
case DeleteEventsCompleted(toSequenceNr) =>
ctx.log.debug("Events successfully deleted to sequence number [{}].", toSequenceNr)
case DeleteEventsFailed(toSequenceNr, failure) => case DeleteEventsFailed(toSequenceNr, failure) =>
ctx.log.warning("Failed to delete messages toSequenceNr [{}] due to [{}].", toSequenceNr, failure) ctx.log.warning("Failed to delete events to sequence number [{}] due to [{}].", toSequenceNr, failure)
} }
Behaviors Behaviors