raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Improve logging in DistributedData extension (#27051)

Browse source 
* and don't load extension from ClusterReceptionist since that will
  trigger the warning logging if role is defined
This commit is contained in:
Patrik Nordwall 2019-06-03 09:31:28 +02:00 • committed by GitHub
parent c5e9b5918c
commit 375228273f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
akka-distributed-data/src/main/scala/akka/cluster/ddata/DistributedData.scala
View file

@ -11,6 +11,7 @@ import akka.actor.Extension
import akka.actor.ExtensionId
import akka.actor.ExtensionIdProvider
import akka.cluster.{ Cluster, UniqueAddress }
import akka.event.Logging
object DistributedData extends ExtensionId[DistributedData] with ExtensionIdProvider {
override def get(system: ActorSystem): DistributedData = super.get(system)
@ -37,8 +38,15 @@ class DistributedData(system: ExtendedActorSystem) extends Extension {
*/
val replicator: ActorRef =
if (isTerminated) {
system.log.warning(
"Replicator points to dead letters: Make sure the cluster node is not terminated and has the proper role!")
val log = Logging(system, getClass)
if (Cluster(system).isTerminated)
log.warning("Replicator points to dead letters, because Cluster is terminated.")
else
log.warning(
"Replicator points to dead letters. Make sure the cluster node has the proper role. " +
"Node has roles [], Distributed Data is configured for roles []",
Cluster(system).selfRoles.mkString(","),
settings.roles.mkString(","))
system.deadLetters
} else {
system.systemActorOf(Replicator.props(settings), ReplicatorSettings.name(system, None))