From 34df60a22f202479529a184ca803685e4801bcfc Mon Sep 17 00:00:00 2001 From: Arnout Engelen Date: Mon, 11 Apr 2022 16:13:47 +0200 Subject: [PATCH] some minor wording updates (#31326) --- .../src/test/scala/akka/actor/ActorPathSpec.scala | 2 +- .../src/main/scala/akka/stream/EmptySourceBenchmark.scala | 2 +- akka-docs/src/main/paradox/persistence-schema-evolution.md | 2 +- .../src/test/scala/akka/persistence/PersistentActorSpec.scala | 2 +- .../akka/persistence/journal/InmemEventAdaptersSpec.scala | 2 +- .../scala/akka/remote/artery/compress/CompressionTable.scala | 2 +- .../scala/akka/stream/impl/fusing/InterpreterStressSpec.scala | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/akka-actor-tests/src/test/scala/akka/actor/ActorPathSpec.scala b/akka-actor-tests/src/test/scala/akka/actor/ActorPathSpec.scala index 36dc3feebb..abf12788d9 100644 --- a/akka-actor-tests/src/test/scala/akka/actor/ActorPathSpec.scala +++ b/akka-actor-tests/src/test/scala/akka/actor/ActorPathSpec.scala @@ -86,7 +86,7 @@ class ActorPathSpec extends AnyWordSpec with Matchers { RootActorPath(Address("akka", "mysys"), "/user/boom/*") // illegally pass in a path where name is expected }.getMessage should include("is a path separator") - // sanity check that creating such path still works + // check that creating such path still works ActorPath.fromString("akka://mysys/user/boom/*") } diff --git a/akka-bench-jmh/src/main/scala/akka/stream/EmptySourceBenchmark.scala b/akka-bench-jmh/src/main/scala/akka/stream/EmptySourceBenchmark.scala index 51d4f3755c..2e2a6a3ade 100644 --- a/akka-bench-jmh/src/main/scala/akka/stream/EmptySourceBenchmark.scala +++ b/akka-bench-jmh/src/main/scala/akka/stream/EmptySourceBenchmark.scala @@ -31,7 +31,7 @@ class EmptySourceBenchmark { Await.result(setup.run(), Duration.Inf) /* - (not serious benchmark, just sanity check: run on macbook 15, late 2013) + (not serious benchmark, just ballpark check: run on macbook 15, late 2013) While it was a PublisherSource: [info] EmptySourceBenchmark.empty thrpt 10 11.219 ± 6.498 ops/ms diff --git a/akka-docs/src/main/paradox/persistence-schema-evolution.md b/akka-docs/src/main/paradox/persistence-schema-evolution.md index 384113d925..6183402056 100644 --- a/akka-docs/src/main/paradox/persistence-schema-evolution.md +++ b/akka-docs/src/main/paradox/persistence-schema-evolution.md @@ -332,7 +332,7 @@ changes in the message format. ### Remove event class and ignore events **Situation:** -While investigating app performance you notice that insane amounts of `CustomerBlinked` events are being stored +While investigating app performance you notice that unreasonable amounts of `CustomerBlinked` events are being stored for every customer each time he/she blinks. Upon investigation, you decide that the event does not add any value and should be deleted. You still have to be able to replay from a journal which contains those old CustomerBlinked events though. diff --git a/akka-persistence/src/test/scala/akka/persistence/PersistentActorSpec.scala b/akka-persistence/src/test/scala/akka/persistence/PersistentActorSpec.scala index cda621a83a..1b386af737 100644 --- a/akka-persistence/src/test/scala/akka/persistence/PersistentActorSpec.scala +++ b/akka-persistence/src/test/scala/akka/persistence/PersistentActorSpec.scala @@ -1247,7 +1247,7 @@ abstract class PersistentActorSpec(config: Config) extends PersistenceSpec(confi acks should equal(expectedAcks) } "reply to the original sender() of a command, even when using persistAsync" in { - // sanity check, the setting of sender() for PersistentRepl is handled by PersistentActor currently + // the setting of sender() for PersistentRepl is handled by PersistentActor currently // but as we want to remove it soon, keeping the explicit test here. val persistentActor = asyncPersistThreeTimesPersistentActor diff --git a/akka-persistence/src/test/scala/akka/persistence/journal/InmemEventAdaptersSpec.scala b/akka-persistence/src/test/scala/akka/persistence/journal/InmemEventAdaptersSpec.scala index 9ee821ca79..2027a7abcd 100644 --- a/akka-persistence/src/test/scala/akka/persistence/journal/InmemEventAdaptersSpec.scala +++ b/akka-persistence/src/test/scala/akka/persistence/journal/InmemEventAdaptersSpec.scala @@ -57,7 +57,7 @@ class InmemEventAdaptersSpec extends AkkaSpec { "pick the most specific adapter available" in { val adapters = EventAdapters(extendedActorSystem, inmemConfig) - // sanity check; precise case, matching non-user classes + // precise case, matching non-user classes adapters.get(classOf[java.lang.String]).getClass should ===(classOf[ExampleEventAdapter]) // pick adapter by implemented marker interface diff --git a/akka-remote/src/main/scala/akka/remote/artery/compress/CompressionTable.scala b/akka-remote/src/main/scala/akka/remote/artery/compress/CompressionTable.scala index 38a65a66f7..5e7426685b 100644 --- a/akka-remote/src/main/scala/akka/remote/artery/compress/CompressionTable.scala +++ b/akka-remote/src/main/scala/akka/remote/artery/compress/CompressionTable.scala @@ -33,7 +33,7 @@ private[remote] final class CompressionTable[T]( def invert: DecompressionTable[T] = if (_dictionary.isEmpty) DecompressionTable.empty[T].copy(originUid = originUid, version = version) else { - // TODO: these are some expensive sanity checks, about the numbers being consecutive, without gaps + // TODO: these are some expensive checks, about the numbers being consecutive, without gaps // TODO: we can remove them, make them re-map (not needed I believe though) val expectedGaplessSum = Integer.valueOf((_dictionary.size * (_dictionary.size + 1)) / 2) /* Dirichlet */ import akka.util.ccompat.JavaConverters._ diff --git a/akka-stream-tests/src/test/scala/akka/stream/impl/fusing/InterpreterStressSpec.scala b/akka-stream-tests/src/test/scala/akka/stream/impl/fusing/InterpreterStressSpec.scala index d4f0f632a5..8d9bc06c9c 100644 --- a/akka-stream-tests/src/test/scala/akka/stream/impl/fusing/InterpreterStressSpec.scala +++ b/akka-stream-tests/src/test/scala/akka/stream/impl/fusing/InterpreterStressSpec.scala @@ -43,7 +43,7 @@ class InterpreterStressSpec extends StreamSpec with GraphInterpreterSpecKit { lastEvents() should be(Set(OnComplete)) val time = (System.nanoTime() - tstamp) / (1000.0 * 1000.0 * 1000.0) - // Not a real benchmark, just for sanity check + // Not a real benchmark, just for ballpark check info(s"Chain finished in $time seconds ${(chainLength * repetition) / (time * 1000 * 1000)} million maps/s") } @@ -73,7 +73,7 @@ class InterpreterStressSpec extends StreamSpec with GraphInterpreterSpecKit { Set(Cancel(SubscriptionWithCancelException.StageWasCompleted), OnComplete, OnNext(0 + chainLength))) val time = (System.nanoTime() - tstamp) / (1000.0 * 1000.0 * 1000.0) - // Not a real benchmark, just for sanity check + // Not a real benchmark, just for ballpark check info(s"Chain finished in $time seconds ${(chainLength * repetition) / (time * 1000 * 1000)} million maps/s") }