raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Add startPosition option for FileIO API

Browse source 
* New startPosition parameter to FileIO.toPath
* New startPosition parameter to FileIO.fromPath
* default startPosition value : 0
* fix binary compatibilities
* Add the MiMa filters for the internal classes
* Feedback from comments of the PR
This commit is contained in:
Cedric CORBIERE 2017-03-30 08:52:35 +02:00 • committed by Patrik Nordwall
parent 082507973a
commit 33ce3f0b77
9 changed files with 171 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

9
akka-stream/src/main/scala/akka/stream/impl/io/IOSources.scala
View file

@ -21,16 +21,17 @@ import scala.concurrent.{ Future, Promise }
* INTERNAL API
* Creates simple synchronous Source backed by the given file.
*/
@InternalApi private[akka] final class FileSource(f: Path, chunkSize: Int, val attributes: Attributes, shape: SourceShape[ByteString])
@InternalApi private[akka] final class FileSource(f: Path, chunkSize: Int, startPosition: Long, val attributes: Attributes, shape: SourceShape[ByteString])
extends SourceModule[ByteString, Future[IOResult]](shape) {
require(chunkSize > 0, "chunkSize must be greater than 0")
require(startPosition >= 0, "startPosition must be equal or greater than 0")
override def create(context: MaterializationContext) = {
// FIXME rewrite to be based on GraphStage rather than dangerous downcasts
val materializer = ActorMaterializerHelper.downcast(context.materializer)
val settings = materializer.effectiveSettings(context.effectiveAttributes)
val ioResultPromise = Promise[IOResult]()
val props = FilePublisher.props(f, ioResultPromise, chunkSize, settings.initialInputBufferSize, settings.maxInputBufferSize)
val props = FilePublisher.props(f, ioResultPromise, chunkSize, startPosition, settings.initialInputBufferSize, settings.maxInputBufferSize)
val dispatcher = context.effectiveAttributes.get[Dispatcher](IODispatcher).dispatcher
val ref = materializer.actorOf(context, props.withDispatcher(dispatcher))
@ -39,10 +40,10 @@ import scala.concurrent.{ Future, Promise }
}
override protected def newInstance(shape: SourceShape[ByteString]): SourceModule[ByteString, Future[IOResult]] =
new FileSource(f, chunkSize, attributes, shape)
new FileSource(f, chunkSize, startPosition, attributes, shape)
override def withAttributes(attr: Attributes): SourceModule[ByteString, Future[IOResult]] =
new FileSource(f, chunkSize, attr, amendShape(attr))
new FileSource(f, chunkSize, startPosition, attr, amendShape(attr))
override protected def label: String = s"FileSource($f, $chunkSize)"
}